Mojom runtime type info: New implementation for Dart.

mojo/dart/apptests/dart_apptests/lib/src/service_describer_apptests.dart

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 library service_describer_apptests;
 
 import 'dart:async';
 
 import 'package:mojo_apptest/apptest.dart';
 import 'package:mojo/application.dart';
@@ skipping 30 matching lines @@
       var ed = echo_service.EchoServiceStub.serviceDescription;
 
       Function identity = (v) => v;
 
       // Top-level Mojom Interfaces must match.
       mojom_types.MojomInterface a =
           (await sd.getTopLevelInterface()).mojomInterface;
       mojom_types.MojomInterface b = ed.getTopLevelInterface(identity);
       _compare(a, b);
 
-      String interfaceID = "echo_service_EchoService__";
-      mojom_types.MojomInterface c =
-          (await sd.getTypeDefinition(interfaceID)).type.interfaceType;
-      mojom_types.MojomInterface d =
-          ed.getTypeDefinition(interfaceID, identity).interfaceType;
-      _compare(a, c);
-      _compare(c, d);

[alexfandrianto, 2016/03/02 05:27:12]

Does this part of the test need to be removed? If possible, I'd like to keep it
so that we can verify that getTypeDefinition is implemented correctly.

If the problem is the type key, we can reuse the computeTypeKey function (and
TODO) you wrote for the embedder test.

+// computeTypeKey encapsulates the algorithm for computing the type key
+// of a type given its fully-qualified name.
+//
+// TODO(rudominer) Delete this when we add accessors for Mojom types
+// in the Dart bindings.
+String computeTypeKey(String fullyQualifiedName) {
+  return "TYPE_KEY:" + fullyQualifiedName;
+}
+

[rudominer, 2016/03/03 01:09:36]

OK here is what I did: I switched this test to query the PingPongService instead
of the EchoService because the PingPongService uses more than one Mojom type.
Now we can test using getTypeDefinition() the way it is supposed to be used.

-
       // Check that the mojom type definitions match between mappings.
       // For simplicity, check in a shallow manner.
       var actualDescriptions = (await sd.getAllTypeDefinitions()).definitions;
       var expectedDescriptions = ed.getAllTypeDefinitions(identity);
       actualDescriptions.keys.forEach((String key) {
         var a = actualDescriptions[key];
         var e = expectedDescriptions[key];
         expect(e, isNotNull);
         expect(a.runtimeType, equals(e.runtimeType));
       });
@@ skipping 29 matching lines @@
     expect(methodA.parameters.fields.length,
         equals(methodB.parameters.fields.length));
     mojom_types.MojomStruct responseA = methodA.responseParams;
     mojom_types.MojomStruct responseB = methodB.responseParams;
     expect(responseA == null, equals(responseB == null));
     if (responseA != null) {
       expect(responseA.fields.length, equals(responseB.fields.length));
     }
   });
 }