[InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition

third_party/WebKit/Source/core/editing/EditingUtilities.cpp

Index: third_party/WebKit/Source/core/editing/EditingUtilities.cpp
diff --git a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
index b1969288e1236da78496692d17fcb110eb3ab03a..ea27a285e618e40ab2c8c62bf85fccdbd1675a5f 100644
--- a/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
+++ b/third_party/WebKit/Source/core/editing/EditingUtilities.cpp
@@ -1731,4 +1731,37 @@ bool isTextSecurityNode(const Node* node)
     return node && node->layoutObject() && node->layoutObject()->style()->textSecurity() != TSNONE;
 }
 
+DispatchEventResult dispatchBeforeInputInsertText(EventTarget* target, const String& data)
+{
+    if (RuntimeEnabledFeatures::inputEventEnabled()) {

[yosin_UTC9, 2016/04/13 06:13:09]

Could you use early return style to reduce indentation and diff when we get rid
of runtime flag.

# We just remove this if-statement when we get rid of runtime flag.
if (!RuntimeEnabledFeatures::inputEventEnabled())
    return DispatchEventResult::NotCanceled;
if (!target)
    return DispatchEventResult::NotCanceled;
InputEvent* beforeInputEvent =
InputEvent::createBeforeInputTyping(InputEvent::InputType::InsertText, data);
return target->dispatchEvent(beforeInputEvent);

[chongz, 2016/04/13 23:53:08]

Done.

+        if (target) {
+            InputEvent* beforeInputEvent = InputEvent::createBeforeInputTyping(InputEvent::InputType::InsertText, data);
+            return target->dispatchEvent(beforeInputEvent);
+        }
+    }
+    return DispatchEventResult::NotCanceled;
+}
+
+DispatchEventResult dispatchBeforeInputFromComposition(EventTarget* target, InputEvent::InputType inputType, const String& data)
+{
+    if (RuntimeEnabledFeatures::inputEventEnabled()) {
+        if (target) {
+            InputEvent* beforeInputEvent = InputEvent::createBeforeInputFromComposition(inputType, data);
+            return target->dispatchEvent(beforeInputEvent);
+        }
+    }
+    return DispatchEventResult::NotCanceled;
+}
+
+DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget* target, InputEvent::InputType inputType, const String& data)
+{
+    if (RuntimeEnabledFeatures::inputEventEnabled()) {
+        if (target) {
+            InputEvent* beforeInputEvent = InputEvent::createBeforeInputEditorCommand(inputType, data);
+            return target->dispatchEvent(beforeInputEvent);
+        }
+    }
+    return DispatchEventResult::NotCanceled;
+}
+
 } // namespace blink