[InputEvent] Fire 'beforeinput' during typing, pressing hot keys and IME composition

third_party/WebKit/Source/core/editing/EditingUtilities.cpp

 /*
  * Copyright (C) 2004, 2005, 2006, 2007 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 1713 matching lines @@
     // otherwise, make sure to be at the start of the first selected node,
     // instead of possibly at the end of the last node before the selection
     return mostForwardCaretPosition(visiblePosition.deepEquivalent());
 }
 
 bool isTextSecurityNode(const Node* node)
 {
     return node && node->layoutObject() && node->layoutObject()->style()->textSecurity() != TSNONE;
 }
 
+DispatchEventResult dispatchBeforeInputInsertText(EventTarget* target, const String& data)
+{
+    if (RuntimeEnabledFeatures::inputEventEnabled()) {

[yosin_UTC9, 2016/04/13 06:13:09]

Could you use early return style to reduce indentation and diff when we get rid
of runtime flag.

# We just remove this if-statement when we get rid of runtime flag.
if (!RuntimeEnabledFeatures::inputEventEnabled())
    return DispatchEventResult::NotCanceled;
if (!target)
    return DispatchEventResult::NotCanceled;
InputEvent* beforeInputEvent =
InputEvent::createBeforeInputTyping(InputEvent::InputType::InsertText, data);
return target->dispatchEvent(beforeInputEvent);

[chongz, 2016/04/13 23:53:08]

Done.

+        if (target) {
+            InputEvent* beforeInputEvent = InputEvent::createBeforeInputTyping(InputEvent::InputType::InsertText, data);
+            return target->dispatchEvent(beforeInputEvent);
+        }
+    }
+    return DispatchEventResult::NotCanceled;
+}
+
+DispatchEventResult dispatchBeforeInputFromComposition(EventTarget* target, InputEvent::InputType inputType, const String& data)
+{
+    if (RuntimeEnabledFeatures::inputEventEnabled()) {
+        if (target) {
+            InputEvent* beforeInputEvent = InputEvent::createBeforeInputFromComposition(inputType, data);
+            return target->dispatchEvent(beforeInputEvent);
+        }
+    }
+    return DispatchEventResult::NotCanceled;
+}
+
+DispatchEventResult dispatchBeforeInputEditorCommand(EventTarget* target, InputEvent::InputType inputType, const String& data)
+{
+    if (RuntimeEnabledFeatures::inputEventEnabled()) {
+        if (target) {
+            InputEvent* beforeInputEvent = InputEvent::createBeforeInputEditorCommand(inputType, data);
+            return target->dispatchEvent(beforeInputEvent);
+        }
+    }
+    return DispatchEventResult::NotCanceled;
+}
+
 } // namespace blink