Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Issue 1752813002: Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. (Closed)

Created:
4 years, 9 months ago by oshima
Modified:
4 years, 9 months ago
Reviewers:
oshima
CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2661
Target Ref:
refs/pending/branch-heads/2661
Project:
chromium
Visibility:
Public.

Description

Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869, 485650 TBR=oshima@chromium.org Review URL: https://codereview.chromium.org/1745523002 Cr-Commit-Position: refs/heads/master@{#378153} (cherry picked from commit 131114a6dd70fabb949d7f05f3c9759bcf701281) Committed: https://chromium.googlesource.com/chromium/src/+/ab5b607f62fc15e879a6c0c939774660a620796b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M content/renderer/render_widget_fullscreen_pepper.h View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/render_widget_fullscreen_pepper.cc View 1 chunk +2 lines, -4 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
oshima
4 years, 9 months ago (2016-03-01 17:39:35 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ab5b607f62fc15e879a6c0c939774660a620796b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698