Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1745523002:
Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. (Closed)
|
Created:
4 years, 10 months ago by oshima Modified:
4 years, 9 months ago CC:
chromium-reviews, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, jam, darin-cc_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionPepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor.
RenderWidget::OnDeviceScaleFactorChanegd calls
setPaintedDeviceScaleFactor, which does not work for pepper.
I apparently forgot to handle this in https://codereview.chromium.org/1609193002.
BUG=589869, 485650
Committed: https://crrev.com/131114a6dd70fabb949d7f05f3c9759bcf701281
Cr-Commit-Position: refs/heads/master@{#378153}
Patch Set 1 : #
Messages
Total messages: 25 (16 generated)
Description was changed from ========== Fullscreen BUG= ========== to ========== Pepper flash should use cc's device scale factor not painted devic escale factor BUG=589869,485650 ==========
oshima@chromium.org changed reviewers: + bbudge@chromium.org
Description was changed from ========== Pepper flash should use cc's device scale factor not painted devic escale factor BUG=589869,485650 ========== to ========== Pepper flash uses DIP, so it should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. BUG=589869,485650 ==========
Patchset #1 (id:1) has been deleted
Patchset #1 (id:20001) has been deleted
Patchset #1 (id:40001) has been deleted
Patchset #1 (id:60001) has been deleted
Patchset #1 (id:80001) has been deleted
Description was changed from ========== Pepper flash uses DIP, so it should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. BUG=589869,485650 ========== to ========== Pepper flash uses DIP, so it should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869,485650 ==========
The CQ bit was checked by oshima@chromium.org to run a CQ dry run
Description was changed from ========== Pepper flash uses DIP, so it should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869,485650 ========== to ========== Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869,485650 ==========
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745523002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745523002/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
LGTM but I'm not an OWNER in content/renderer
oshima@chromium.org changed reviewers: + avi@chromium.org
avi@ -> content/renderer owner.
lgtm stamp
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1745523002/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1745523002/100001
Message was sent while issue was closed.
Description was changed from ========== Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869,485650 ========== to ========== Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869,485650 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:100001)
Message was sent while issue was closed.
Description was changed from ========== Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869,485650 ========== to ========== Pepper uses DIP, so RWFullscreenPepper should always use SetDeviceScaleFctor. RenderWidget::OnDeviceScaleFactorChanegd calls setPaintedDeviceScaleFactor, which does not work for pepper. I apparently forgot to handle this in https://codereview.chromium.org/1609193002. BUG=589869,485650 Committed: https://crrev.com/131114a6dd70fabb949d7f05f3c9759bcf701281 Cr-Commit-Position: refs/heads/master@{#378153} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/131114a6dd70fabb949d7f05f3c9759bcf701281 Cr-Commit-Position: refs/heads/master@{#378153} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
