Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 1752773003: Check @apply syntax in custom properties declarations at parse time (Closed)

Created:
4 years, 9 months ago by Timothy Loh
Modified:
4 years, 9 months ago
Reviewers:
dstockwell, shans
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check @apply syntax in custom properties declarations at parse time This patch moves syntax checking for @apply references inside custom property declarations from style computation to parse time. This makes us reject any custom property declarations which has an invalid @apply rule, such as "--foo: @apply bar". BUG=586974 Committed: https://crrev.com/fc5aafd0c036e4b939ebd6ef2e014a97b7add807 Cr-Commit-Position: refs/heads/master@{#379747}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-syntax.html View 2 chunks +11 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSVariableParser.cpp View 1 chunk +7 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/CSSVariableResolver.cpp View 2 chunks +1 line, -9 lines 0 comments Download

Messages

Total messages: 12 (6 generated)
Timothy Loh
4 years, 9 months ago (2016-03-02 03:04:13 UTC) #2
dstockwell
lgtm
4 years, 9 months ago (2016-03-08 01:28:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752773003/1
4 years, 9 months ago (2016-03-08 01:40:20 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752773003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752773003/1
4 years, 9 months ago (2016-03-08 02:05:29 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-08 04:55:26 UTC) #10
commit-bot: I haz the power
4 years, 9 months ago (2016-03-08 04:56:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fc5aafd0c036e4b939ebd6ef2e014a97b7add807
Cr-Commit-Position: refs/heads/master@{#379747}

Powered by Google App Engine
This is Rietveld 408576698