third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html - Issue 1752773003: Check @apply syntax in custom properties declarations at parse time

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html

Issue 1752773003: Check @apply syntax in custom properties declarations at parse time (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html

diff --git a/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html b/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html

index e0a472f75dee65f36c3337a1fca6c87fee1f154d..00df0c6e2cb2db0755ea072087e8b7848bfa2986 100644

--- a/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html

+++ b/third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-nesting.html

@@ -11,7 +11,7 @@

--red: { background-color: red; };

--foo: {

background-color: green;

- var(--apply1) var(--apply2);

+ var(--apply1, ) var(--apply2, );

};

@apply --foo;

}

@@ -21,7 +21,8 @@

test(function(){

assert_equals(getComputedStyle(e).backgroundColor, "rgb(0, 128, 0)");

- assert_equals(getComputedStyle(e).getPropertyValue("--foo"), " { background-color: green; @apply --red; }");

+ assert_equals(getComputedStyle(e).getPropertyValue("--apply1"), "");

+ assert_equals(getComputedStyle(e).getPropertyValue("--foo"), " { background-color: green; --red; }");

}, "@apply inside custom properties don't get expanded if the @apply rule was " +

"constructed from variable references");

</script>

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/fast/css/atapply/at-apply-invalid-syntax.html » ('j') | no next file with comments »