Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(687)

Issue 1752503002: Change function source fingerprint calculation to rely on tokens exclusively and (Closed)

Created:
4 years, 9 months ago by regis
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Change function source fingerprint calculation to rely on tokens exclusively and not on the signature type hash anymore. This makes fingerprints insensitive to implementation details of the type system. The signature type hash was included because, in the early days, the token stream of a function started at the opening brace and did not include tokens representing the signature. R=srdjan@google.com Committed: https://github.com/dart-lang/sdk/commit/e66d65f7b97cb763347a4f70f3fad711bda18dba

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+429 lines, -430 lines) Patch
M runtime/vm/method_recognizer.h View 3 chunks +423 lines, -426 lines 0 comments Download
M runtime/vm/object.cc View 1 chunk +1 line, -3 lines 0 comments Download
M runtime/vm/object_test.cc View 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
regis
4 years, 9 months ago (2016-02-29 22:20:49 UTC) #2
srdjan
STV, LGTM
4 years, 9 months ago (2016-02-29 22:55:53 UTC) #3
regis
4 years, 9 months ago (2016-02-29 22:59:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
e66d65f7b97cb763347a4f70f3fad711bda18dba (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698