Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(386)

Unified Diff: runtime/vm/object_test.cc

Issue 1752503002: Change function source fingerprint calculation to rely on tokens exclusively and (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/object_test.cc
diff --git a/runtime/vm/object_test.cc b/runtime/vm/object_test.cc
index 6622d8bd7bca4d3e6872b799cef2585628a933b5..e793b9bb1d870e785bfc0dc36511f9b20f9af400 100644
--- a/runtime/vm/object_test.cc
+++ b/runtime/vm/object_test.cc
@@ -4034,7 +4034,11 @@ TEST_CASE(FunctionSourceFingerprint) {
EXPECT_NE(a_test3.SourceFingerprint(), a_test4.SourceFingerprint());
EXPECT_NE(a_test4.SourceFingerprint(), a_test5.SourceFingerprint());
EXPECT_EQ(a_test5.SourceFingerprint(), b_test5.SourceFingerprint());
- EXPECT_NE(a_test6.SourceFingerprint(), b_test6.SourceFingerprint());
+ // Although a_test6's receiver type is different than b_test6's receiver type,
+ // the fingerprints are identical. The token stream does not reflect the
+ // receiver's type. This is not a problem, since we recognize functions
+ // of a given class and of a given name.
+ EXPECT_EQ(a_test6.SourceFingerprint(), b_test6.SourceFingerprint());
}
« no previous file with comments | « runtime/vm/object.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698