Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Issue 1752453002: Revert of Timeline: extract and rename TracingModelLoader into a file of its own (Closed)

Created:
4 years, 9 months ago by nektarios
Modified:
4 years, 9 months ago
Reviewers:
caseq, alph
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, pfeldman, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Timeline: extract and rename TracingModelLoader into a file of its own (patchset #4 id:60001 of https://codereview.chromium.org/1739193003/ ) Reason for revert: Possible cause behind failure in webkit-tests on WebKit Mac10.11 and WebKit Mac10.11 (retina). Original issue's description: > Timeline: extract and rename TracingModelLoader into a file of its own > > This just extracts TimelineLoader with the aim of later refactoring > it to untangle timeline lifecycle events from TimelineModel. > > Committed: https://crrev.com/b994e8b0a8af48aca6aa2182b5e8157b4873c0e9 > Cr-Commit-Position: refs/heads/master@{#378109} TBR=alph@chromium.org,caseq@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. Committed: https://crrev.com/c4ffa58b1a2c1eb0484dc21b68632e96c070652c Cr-Commit-Position: refs/heads/master@{#378291}

Patch Set 1 #

Messages

Total messages: 9 (1 generated)
nektarios
Created Revert of Timeline: extract and rename TracingModelLoader into a file of its own
4 years, 9 months ago (2016-02-29 20:43:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752453002/1
4 years, 9 months ago (2016-02-29 20:43:58 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752453002/1
4 years, 9 months ago (2016-02-29 21:01:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752453002/1
4 years, 9 months ago (2016-02-29 21:31:42 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752453002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752453002/1
4 years, 9 months ago (2016-02-29 22:02:34 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-02-29 22:26:54 UTC) #6
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/c4ffa58b1a2c1eb0484dc21b68632e96c070652c Cr-Commit-Position: refs/heads/master@{#378291}
4 years, 9 months ago (2016-02-29 22:27:45 UTC) #8
caseq
4 years, 9 months ago (2016-03-01 17:24:40 UTC) #9
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1754713002/ by caseq@chromium.org.

The reason for reverting is: Reverting of revert, it doesn't look to me this was
the culprit in layout test failures..

Powered by Google App Engine
This is Rietveld 408576698