third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html - Issue 1752453002: Revert of Timeline: extract and rename TracingModelLoader into a file of its own

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html

Issue 1752453002: Revert of Timeline: extract and rename TracingModelLoader into a file of its own (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/tracing/timeline-window-filter.html ('k') | third_party/WebKit/Source/devtools/devtools.gypi » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html

diff --git a/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html b/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html

index e4329235fdb7059cedc22e5557512528e6c849ba..da30717547baf54c73afdf857381f16686510d31 100644

--- a/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html

+++ b/third_party/WebKit/LayoutTests/inspector/tracing/tracing-timeline-load.html

@@ -26,8 +26,9 @@

InspectorTest.assertEquals(JSON.stringify(expectedOutput), JSON.stringify(saveData), "saved data is not equal to restored");

}

- InspectorTest.override(WebInspector.TimelineLoader, "_createFileReader", createFileReader);

- WebInspector.TimelineLoader.loadFromFile(model, {}, new WebInspector.Progress());

+ InspectorTest.override(model, "_createFileReader", createFileReader);

+ model.loadFromFile({}, new WebInspector.Progress());

}

function runTestOnMalformedInput(input)

@@ -45,8 +46,8 @@

InspectorTest.assertTrue(model.isEmpty());

}

- InspectorTest.override(WebInspector.TimelineLoader, "_createFileReader", createFileReader);

- WebInspector.TimelineLoader.loadFromFile(model, {}, new WebInspector.Progress());

+ InspectorTest.override(model, "_createFileReader", createFileReader);

+ model.loadFromFile({}, new WebInspector.Progress());

}

var data = [{"args":{"number":32},"cat":"__metadata","name":"num_cpus","ph":"M","pid":32127,"tid":0,"ts":0},