Add LayerTreeImpl end/begin/rend/rbegin

Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/7ee64947b2b915e2014b88238ab8f810ded79a11
Cr-Commit-Position: refs/heads/master@{#378967}

[Ian Vollick, 2016-03-02 23:02:40]

Description was changed from

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
==========

to

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Ian Vollick, 2016-03-02 23:02:53]

Description was changed from

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[Ian Vollick, 2016-03-02 23:02:53]

vollick@chromium.org changed reviewers:
+ danakj@chromium.org

[Ian Vollick, 2016-03-02 23:04:43]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-02 23:04:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752263003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752263003/1

[Ian Vollick, 2016-03-02 23:07:14]

vollick@chromium.org changed reviewers:
+ ajuma@chromium.org, weiliangc@chromium.org

[Ian Vollick, 2016-03-02 23:07:58]

+some other folks in case they're interested/free.

[commit-bot: I haz the power, 2016-03-03 00:19:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-03 00:19:23]

Dry run: This issue passed the CQ dry run.

[ajuma, 2016-03-03 00:20:44]

lgtm

[danakj, 2016-03-03 00:35:50]

LGTM

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
File cc/layers/layer_list_iterator_unittest.cc (right):

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:60: for (auto it :
*host_impl.active_tree()) {
do you mean auto layer? when doing a for loop the variable is the return of
*iterator.

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:82: for (auto it :
*host_impl.active_tree()) {
dittos

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:141: for (auto it :
base::Reversed(*host_impl.active_tree())) {
ditto

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:164: for (auto it :
base::Reversed(*host_impl.active_tree())) {
ditto

https://codereview.chromium.org/1752263003/diff/1/cc/trees/layer_tree_impl.h
File cc/trees/layer_tree_impl.h (right):

https://codereview.chromium.org/1752263003/diff/1/cc/trees/layer_tree_impl.h#...
cc/trees/layer_tree_impl.h:146: LayerListIterator begin();
Can you leave a comment saying what these iterate and in what order?

[danakj, 2016-03-03 00:36:09]

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
File cc/layers/layer_list_iterator_unittest.cc (right):

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:60: for (auto it :
*host_impl.active_tree()) {
On 2016/03/03 00:35:50, danakj wrote:
> do you mean auto layer? when doing a for loop the variable is the return of
> *iterator.

Also if it's a pointer, use auto*

[Ian Vollick, 2016-03-03 04:41:32]

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
File cc/layers/layer_list_iterator_unittest.cc (right):

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:60: for (auto it :
*host_impl.active_tree()) {
On 2016/03/03 00:35:50, danakj wrote:
> do you mean auto layer? when doing a for loop the variable is the return of
> *iterator.

Done.

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:60: for (auto it :
*host_impl.active_tree()) {
On 2016/03/03 00:36:08, danakj wrote:
> On 2016/03/03 00:35:50, danakj wrote:
> > do you mean auto layer? when doing a for loop the variable is the return of
> > *iterator.
> 
> Also if it's a pointer, use auto*

Done.

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:82: for (auto it :
*host_impl.active_tree()) {
On 2016/03/03 00:35:50, danakj wrote:
> dittos

Done.

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:141: for (auto it :
base::Reversed(*host_impl.active_tree())) {
On 2016/03/03 00:35:50, danakj wrote:
> ditto

Done.

https://codereview.chromium.org/1752263003/diff/1/cc/layers/layer_list_iterat...
cc/layers/layer_list_iterator_unittest.cc:164: for (auto it :
base::Reversed(*host_impl.active_tree())) {
On 2016/03/03 00:35:50, danakj wrote:
> ditto

Done.

[Ian Vollick, 2016-03-03 04:42:09]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2016-03-03 04:42:10]

The patchset sent to the CQ was uploaded after l-g-t-m from danakj@chromium.org,
ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/1752263003/#ps20001
(title: "address reviewer feedback")

[commit-bot: I haz the power, 2016-03-03 04:42:18]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1752263003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1752263003/20001

[commit-bot: I haz the power, 2016-03-03 05:55:43]

Description was changed from

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-03-03 05:55:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-03 05:56:35]

Description was changed from

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Add LayerTreeImpl end/begin/rend/rbegin

This also allows for some pretty cute ways to iterate. See some
examples in the unit test.

BUG=None
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/7ee64947b2b915e2014b88238ab8f810ded79a11
Cr-Commit-Position: refs/heads/master@{#378967}
==========

[commit-bot: I haz the power, 2016-03-03 05:56:36]

Patchset 2 (id:??) landed as
https://crrev.com/7ee64947b2b915e2014b88238ab8f810ded79a11
Cr-Commit-Position: refs/heads/master@{#378967}