Add LayerTreeImpl end/begin/rend/rbegin

cc/layers/layer_list_iterator_unittest.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/layers/layer_list_iterator.h"
 
+#include "base/containers/adapters.h"
 #include "base/memory/scoped_ptr.h"
 #include "cc/test/fake_impl_task_runner_provider.h"
 #include "cc/test/fake_layer_tree_host_impl.h"
 #include "cc/test/fake_output_surface.h"
 #include "cc/test/test_shared_bitmap_manager.h"
 #include "cc/test/test_task_graph_runner.h"
+#include "cc/trees/layer_tree_impl.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace cc {
 namespace {
 
 TEST(LayerListIteratorTest, VerifyTraversalOrder) {
   // Unfortunate preamble.
   FakeImplTaskRunnerProvider task_runner_provider;
   TestSharedBitmapManager shared_bitmap_manager;
   TestTaskGraphRunner task_graph_runner;
@@ skipping 22 matching lines @@
 
   layer2->AddChild(std::move(layer3));
   layer2->AddChild(std::move(layer4));
 
   layer5->AddChild(std::move(layer6));
   layer5->AddChild(std::move(layer7));
 
   layer1->AddChild(std::move(layer2));
   layer1->AddChild(std::move(layer5));
 
+  host_impl.active_tree()->SetRootLayer(std::move(layer1));
+
   int i = 1;
-  LayerListIterator it(layer1.get());
-  LayerListIterator end(nullptr);
-  for (; it != end; ++it, ++i) {
-    EXPECT_EQ(i, it->id());
+  for (auto it : *host_impl.active_tree()) {

[danakj, 2016/03/03 00:35:50]

do you mean auto layer? when doing a for loop the variable is the return of
*iterator.

[danakj, 2016/03/03 00:36:08]

Also if it's a pointer, use auto*

[Ian Vollick, 2016/03/03 04:41:31]

Done.

[Ian Vollick, 2016/03/03 04:41:31]

Done.

+    EXPECT_EQ(i++, it->id());
   }
   EXPECT_EQ(8, i);
 }
 
 TEST(LayerListIteratorTest, VerifySingleLayer) {
   // Unfortunate preamble.
   FakeImplTaskRunnerProvider task_runner_provider;
   TestSharedBitmapManager shared_bitmap_manager;
   TestTaskGraphRunner task_graph_runner;
   scoped_ptr<OutputSurface> output_surface = FakeOutputSurface::Create3d();
   FakeLayerTreeHostImpl host_impl(&task_runner_provider, &shared_bitmap_manager,
                                   &task_graph_runner);
   host_impl.SetVisible(true);
   EXPECT_TRUE(host_impl.InitializeRenderer(output_surface.get()));
 
   // This test constructs a tree consisting of a single layer.
   scoped_ptr<LayerImpl> layer1 = LayerImpl::Create(host_impl.active_tree(), 1);
+  host_impl.active_tree()->SetRootLayer(std::move(layer1));
+
   int i = 1;
-  LayerListIterator it(layer1.get());
-  LayerListIterator end(nullptr);
-  for (; it != end; ++it, ++i) {
-    EXPECT_EQ(i, it->id());
+  for (auto it : *host_impl.active_tree()) {

[danakj, 2016/03/03 00:35:50]

dittos

[Ian Vollick, 2016/03/03 04:41:31]

Done.

+    EXPECT_EQ(i++, it->id());
   }
   EXPECT_EQ(2, i);
 }
 
 TEST(LayerListIteratorTest, VerifyNullFirstLayer) {
   // Ensures that if an iterator is constructed with a nullptr, that it can be
   // iterated without issue and that it remains equal to any other
   // null-initialized iterator.
   LayerListIterator it(nullptr);
   LayerListIterator end(nullptr);
@@ skipping 33 matching lines @@
 
   layer2->AddChild(std::move(layer3));
   layer2->AddChild(std::move(layer4));
 
   layer5->AddChild(std::move(layer6));
   layer5->AddChild(std::move(layer7));
 
   layer1->AddChild(std::move(layer2));
   layer1->AddChild(std::move(layer5));
 
+  host_impl.active_tree()->SetRootLayer(std::move(layer1));
+
   int i = 7;
-  LayerListReverseIterator it(layer1.get());
-  LayerListReverseIterator end(nullptr);
-  for (; it != end; ++it, --i) {
-    EXPECT_EQ(i, it->id());
+
+  for (auto it : base::Reversed(*host_impl.active_tree())) {

[danakj, 2016/03/03 00:35:50]

ditto

[Ian Vollick, 2016/03/03 04:41:31]

Done.

+    EXPECT_EQ(i--, it->id());
   }
+
   EXPECT_EQ(0, i);
 }
 
 TEST(LayerListReverseIteratorTest, VerifySingleLayer) {
   // Unfortunate preamble.
   FakeImplTaskRunnerProvider task_runner_provider;
   TestSharedBitmapManager shared_bitmap_manager;
   TestTaskGraphRunner task_graph_runner;
   scoped_ptr<OutputSurface> output_surface = FakeOutputSurface::Create3d();
   FakeLayerTreeHostImpl host_impl(&task_runner_provider, &shared_bitmap_manager,
                                   &task_graph_runner);
   host_impl.SetVisible(true);
   EXPECT_TRUE(host_impl.InitializeRenderer(output_surface.get()));
 
   // This test constructs a tree consisting of a single layer.
   scoped_ptr<LayerImpl> layer1 = LayerImpl::Create(host_impl.active_tree(), 1);
+  host_impl.active_tree()->SetRootLayer(std::move(layer1));
+
   int i = 1;
-  LayerListReverseIterator it(layer1.get());
-  LayerListReverseIterator end(nullptr);
-  for (; it != end; ++it, --i) {
-    EXPECT_EQ(i, it->id());
+  for (auto it : base::Reversed(*host_impl.active_tree())) {

[danakj, 2016/03/03 00:35:50]

ditto

[Ian Vollick, 2016/03/03 04:41:31]

Done.

+    EXPECT_EQ(i--, it->id());
   }
   EXPECT_EQ(0, i);
 }
 
 TEST(LayerListReverseIteratorTest, VerifyNullFirstLayer) {
   // Ensures that if an iterator is constructed with a nullptr, that it can be
   // iterated without issue and that it remains equal to any other
   // null-initialized iterator.
   LayerListReverseIterator it(nullptr);
   LayerListReverseIterator end(nullptr);
 
   EXPECT_EQ(it, end);
   ++it;
   EXPECT_EQ(it, end);
 }
 
 }  // namespace
 }  // namespace cc