content/renderer/media/rtc_video_decoder.cc - Issue 175223003: HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/media/rtc_video_decoder.cc

Issue 175223003: HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Focus on this CL's goal and remove wrong change Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/renderer_host/media/video_capture_controller_unittest.cc ('K') | « content/renderer/media/rtc_video_decoder.h ('k') | content/renderer/media/video_capture_impl.h » ('j') | content/renderer/media/webmediaplayer_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/media/rtc_video_decoder.cc

diff --git a/content/renderer/media/rtc_video_decoder.cc b/content/renderer/media/rtc_video_decoder.cc

index 7171253b246482d1544245b17592e77abda70ece..79eff88a18c47473565d0d15b833d08bcab8fa7a 100644

--- a/content/renderer/media/rtc_video_decoder.cc

+++ b/content/renderer/media/rtc_video_decoder.cc

@@ -639,7 +639,7 @@ void RTCVideoDecoder::ResetInternal() {

void RTCVideoDecoder::ReusePictureBuffer(

int64 picture_buffer_id,

- scoped_ptr<gpu::MailboxHolder> mailbox_holder) {

+ const std::vector<uint32>& release_sync_points) {

DCHECK(vda_task_runner_->BelongsToCurrentThread());

DVLOG(3) << "ReusePictureBuffer. id=" << picture_buffer_id;

@@ -651,7 +651,8 @@ void RTCVideoDecoder::ReusePictureBuffer(

size_t num_erased = picture_buffers_at_display_.erase(picture_buffer_id);

DCHECK(num_erased);

- factories_->WaitSyncPoint(mailbox_holder->sync_point);

+ for (size_t i = 0; i < release_sync_points.size(); i++)

+ factories_->WaitSyncPoint(release_sync_points[i]);

std::map<int32, media::PictureBuffer>::iterator it =

assigned_picture_buffers_.find(picture_buffer_id);