content/browser/renderer_host/media/video_capture_controller.cc - Issue 175223003: HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/media/video_capture_controller.cc

Issue 175223003: HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: Make GpuVideoAcceleratorFactories::ReadPixels() receive mailbox, instead of texture Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/renderer_host/media/video_capture_controller.h ('k') | content/browser/renderer_host/media/video_capture_controller_unittest.cc » ('j') | content/renderer/media/renderer_gpu_video_accelerator_factories.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/media/video_capture_controller.cc

diff --git a/content/browser/renderer_host/media/video_capture_controller.cc b/content/browser/renderer_host/media/video_capture_controller.cc

index 364ee972973814589184db0e1db2c5dfa8e6620c..f3b360cf4eaeb69021733c15848f78de2c18369f 100644

--- a/content/browser/renderer_host/media/video_capture_controller.cc

+++ b/content/browser/renderer_host/media/video_capture_controller.cc

@@ -243,7 +243,7 @@ void VideoCaptureController::ReturnBuffer(

const VideoCaptureControllerID& id,

VideoCaptureControllerEventHandler* event_handler,

int buffer_id,

- uint32 sync_point) {

+ const std::vector<uint32>& sync_points) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));

ControllerClient* client = FindClient(id, event_handler, controller_clients_);

@@ -259,8 +259,10 @@ void VideoCaptureController::ReturnBuffer(

scoped_refptr<media::VideoFrame> frame = iter->second;

client->active_buffers.erase(iter);

- if (frame->format() == media::VideoFrame::NATIVE_TEXTURE)

- frame->mailbox_holder()->sync_point = sync_point;

+ if (frame->format() == media::VideoFrame::NATIVE_TEXTURE) {

+ for (size_t i = 0; i < sync_points.size(); i++)

+ frame->AppendReleaseSyncPoint(sync_points[i]);

+ }

buffer_pool_->RelinquishConsumerHold(buffer_id, 1);

}