cc/resources/video_resource_updater.cc - Issue 175223003: HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: cc/resources/video_resource_updater.cc

Issue 175223003: HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl (Closed) Base URL: https://git.chromium.org/chromium/src.git@master

Patch Set: previous patchset has unrelated code by mistake. Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | content/browser/renderer_host/media/video_capture_controller.h » ('j') | content/browser/renderer_host/media/video_capture_controller.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: cc/resources/video_resource_updater.cc

diff --git a/cc/resources/video_resource_updater.cc b/cc/resources/video_resource_updater.cc

index dee285a28506c651c282418be98a432d2cf88ed5..e6bf21b9cd3dc3b88a4da201b8532e9e9cc10826 100644

--- a/cc/resources/video_resource_updater.cc

+++ b/cc/resources/video_resource_updater.cc

@@ -311,7 +311,7 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForSoftwarePlanes(

static void ReturnTexture(const scoped_refptr<media::VideoFrame>& frame,

uint32 sync_point,

bool lost_resource) {

- frame->mailbox_holder()->sync_point = sync_point;

+ frame->AppendReleaseSyncPoint(sync_point);

}

VideoFrameExternalResources VideoResourceUpdater::CreateForHardwarePlanes(

@@ -343,6 +343,8 @@ VideoFrameExternalResources VideoResourceUpdater::CreateForHardwarePlanes(

return VideoFrameExternalResources();

}

+ // Don't share the mailbox of the video frame with the compositor, because

danakj 2014/03/06 19:31:31 What does this comment mean?

dshwang 2014/03/06 19:51:37 Sorry for broken explanation. ResourceProvider act

+ // the mailbox of the video frame can be read by another thread. i.e. webgl

external_resources.mailboxes.push_back(

TextureMailbox(mailbox_holder->mailbox,

mailbox_holder->texture_target,