HW Video: Make media::VideoFrame handle the sync point of the compositor as well as webgl

content/browser/renderer_host/media/video_capture_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/renderer_host/media/video_capture_controller.h"
 
 #include <map>
 #include <set>
 
 #include "base/bind.h"
@@ skipping 233 matching lines @@
   if (client) {
     client->session_closed = true;
     client->event_handler->OnEnded(client->controller_id);
   }
 }
 
 void VideoCaptureController::ReturnBuffer(
     const VideoCaptureControllerID& id,
     VideoCaptureControllerEventHandler* event_handler,
     int buffer_id,
-    uint32 sync_point) {
+    const std::vector<uint32>& sync_points) {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
 
   ControllerClient* client = FindClient(id, event_handler, controller_clients_);
 
   // If this buffer is not held by this client, or this client doesn't exist
   // in controller, do nothing.
   ControllerClient::ActiveBufferMap::iterator iter;
   if (!client || (iter = client->active_buffers.find(buffer_id)) ==
                      client->active_buffers.end()) {
     NOTREACHED();
     return;
   }
   scoped_refptr<media::VideoFrame> frame = iter->second;
   client->active_buffers.erase(iter);
 
-  if (frame->format() == media::VideoFrame::NATIVE_TEXTURE)
-    frame->mailbox_holder()->sync_point = sync_point;
+  if (frame->format() == media::VideoFrame::NATIVE_TEXTURE) {
+    for (size_t i = 0; i < sync_points.size(); i++)
+      frame->AppendReleaseSyncPoint(sync_points[i]);

[danakj, 2014/03/20 15:59:08]

Do you know where is the callback that will eventually receive these sync
points? I'm trying to follow this back, but the VideoFrames I see are:

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/re...

and 

https://code.google.com/p/chromium/codesearch#chromium/src/content/browser/me...

which are both WrapExternalPackedMemory. I'm failing to see how a native texture
frame would end up here.

[dshwang, 2014/03/20 16:11:20]

That's good question. AFAIK, currently VidoeCaptureController don't create
NATIVE_TEXTURE VideoFrame. It means this code exist just for future.
Ami, jln@, am I right?

[Ami GONE FROM CHROMIUM, 2014/04/11 20:55:17]

Yep.

+  }
 
   buffer_pool_->RelinquishConsumerHold(buffer_id, 1);
 }
 
 const media::VideoCaptureFormat&
 VideoCaptureController::GetVideoCaptureFormat() const {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   return video_capture_format_;
 }
 
@@ skipping 353 matching lines @@
   }
   return NULL;
 }
 
 int VideoCaptureController::GetClientCount() {
   DCHECK(BrowserThread::CurrentlyOn(BrowserThread::IO));
   return controller_clients_.size();
 }
 
 }  // namespace content