Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Issue 1752123002: Check tabmodelselector null on reader mode callback (Closed)

Created:
4 years, 9 months ago by Yusuf
Modified:
4 years, 9 months ago
Reviewers:
mdjones, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Check tabmodelselector null on reader mode callback If the tab is reparented early on before this callback gets back, we hit a NPE. For that callback early return if the TabModelSelector is cleared BUG=590673 Committed: https://crrev.com/d9aa65e5c27433343ebae98db2e23c0610590400 Cr-Commit-Position: refs/heads/master@{#378637}

Patch Set 1 #

Patch Set 2 : return at the beginning #

Patch Set 3 : Early return on request show panel #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java View 1 2 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (7 generated)
Yusuf
4 years, 9 months ago (2016-03-01 23:07:18 UTC) #2
gone
lgtm
4 years, 9 months ago (2016-03-01 23:09:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752123002/20001
4 years, 9 months ago (2016-03-01 23:11:09 UTC) #5
Yusuf
4 years, 9 months ago (2016-03-01 23:27:40 UTC) #8
mdjones
lgtm
4 years, 9 months ago (2016-03-01 23:30:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1752123002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1752123002/40001
4 years, 9 months ago (2016-03-01 23:32:21 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 9 months ago (2016-03-02 00:56:32 UTC) #13
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 00:58:08 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/d9aa65e5c27433343ebae98db2e23c0610590400
Cr-Commit-Position: refs/heads/master@{#378637}

Powered by Google App Engine
This is Rietveld 408576698