Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2806)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java

Issue 1752123002: Check tabmodelselector null on reader mode callback (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Early return on request show panel Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
index 27c8dfeef6f37791fed94700eb84725e94b7d701..48b178066a909adfac9583c6a77fae9f7a180dc7 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/dom_distiller/ReaderModeManager.java
@@ -439,6 +439,8 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
* @param reason The reason the panel is requesting to be shown.
*/
protected void requestReaderPanelShow(StateChangeReason reason) {
+ if (mTabModelSelector == null) return;
+
int currentTabId = mTabModelSelector.getCurrentTabId();
if (currentTabId == Tab.INVALID_TAB_ID) return;
@@ -508,6 +510,8 @@ public class ReaderModeManager extends TabModelSelectorTabObserver
new DistillablePageUtils.PageDistillableDelegate() {
@Override
public void onIsPageDistillableResult(boolean isDistillable, boolean isLast) {
+ if (mTabModelSelector == null) return;
+
ReaderModeTabInfo tabInfo = mTabStatusMap.get(readerTabId);
Tab readerTab = mTabModelSelector.getTabById(readerTabId);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698