Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1397)

Unified Diff: chrome/browser/ui/search/instant_controller.cc

Issue 17521002: Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding mos… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Rebase Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/search/instant_controller.cc
diff --git a/chrome/browser/ui/search/instant_controller.cc b/chrome/browser/ui/search/instant_controller.cc
index fe1cc1bd45c2eada466250960fd566e6f61aa770..4048f97c5c225c26ee0b37afaf72373063878e3f 100644
--- a/chrome/browser/ui/search/instant_controller.cc
+++ b/chrome/browser/ui/search/instant_controller.cc
@@ -1158,23 +1158,14 @@ void InstantController::UpdateMostVisitedItems() {
std::vector<InstantMostVisitedItem> items;
instant_service->GetCurrentMostVisitedItems(&items);
- if (overlay_ && GetOverlayContents() &&
- SearchTabHelper::FromWebContents(overlay_->contents())->
- UpdateLastKnownMostVisitedItems(items)) {
+ if (overlay_)
overlay_->SendMostVisitedItems(items);
- }
- if (ntp_ && ntp_->contents() &&
- SearchTabHelper::FromWebContents(ntp_->contents())->
- UpdateLastKnownMostVisitedItems(items)) {
+ if (ntp_)
ntp_->SendMostVisitedItems(items);
- }
- if (instant_tab_ && instant_tab_->contents() &&
- SearchTabHelper::FromWebContents(instant_tab_->contents())->
- UpdateLastKnownMostVisitedItems(items)) {
+ if (instant_tab_)
instant_tab_->SendMostVisitedItems(items);
- }
content::NotificationService::current()->Notify(
chrome::NOTIFICATION_INSTANT_SENT_MOST_VISITED_ITEMS,

Powered by Google App Engine
This is Rietveld 408576698