Added a check in Searchbox::OnMostVisitedChanged() to prevent duplicate notifications regarding mos…

chrome/browser/ui/search/instant_controller.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/instant_controller.h"
 
 #include <iterator>
 
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_service.h"
@@ skipping 1140 matching lines @@
 
 void InstantController::UpdateMostVisitedItems() {
   InstantService* instant_service =
       InstantServiceFactory::GetForProfile(profile());
   if (!instant_service)
     return;
 
   std::vector<InstantMostVisitedItem> items;
   instant_service->GetCurrentMostVisitedItems(&items);
 
-  if (overlay_ && GetOverlayContents() &&
-      SearchTabHelper::FromWebContents(overlay_->contents())->
-          UpdateLastKnownMostVisitedItems(items)) {
+  if (overlay_)
     overlay_->SendMostVisitedItems(items);
-  }
 
-  if (ntp_ && ntp_->contents() &&
-      SearchTabHelper::FromWebContents(ntp_->contents())->
-          UpdateLastKnownMostVisitedItems(items)) {
+  if (ntp_)
     ntp_->SendMostVisitedItems(items);
-  }
 
-  if (instant_tab_ && instant_tab_->contents() &&
-      SearchTabHelper::FromWebContents(instant_tab_->contents())->
-          UpdateLastKnownMostVisitedItems(items)) {
+  if (instant_tab_)
     instant_tab_->SendMostVisitedItems(items);
-  }
 
   content::NotificationService::current()->Notify(
       chrome::NOTIFICATION_INSTANT_SENT_MOST_VISITED_ITEMS,
       content::Source<InstantController>(this),
       content::NotificationService::NoDetails());
 }
 
 void InstantController::DeleteMostVisitedItem(const GURL& url) {
   DCHECK(!url.is_empty());
   InstantService* instant_service =
@@ skipping 723 matching lines @@
   bool js_webkit_enabled = profile()->GetPrefs()->GetBoolean(
       prefs::kWebKitJavascriptEnabled);
   return js_content_enabled && js_webkit_enabled;
 }
 
 bool InstantController::InStartup() const {
   // TODO(shishir): This is not completely reliable. Find a better way to detect
   // startup time.
   return !browser_->GetActiveWebContents();
 }