Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(613)

Unified Diff: tools/gn/substitution_type.h

Issue 1752033002: Add "create_bundle" target in order to support bundle with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-bundle-data
Patch Set: Add unit tests, address comments, update docs and format with clang-format Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/substitution_type.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/gn/substitution_type.h
diff --git a/tools/gn/substitution_type.h b/tools/gn/substitution_type.h
index 96ae33a32adf98a84099b6866250d8c70a854b89..3f7ec971abd96efc78099d3889ca33b921cfaf9b 100644
--- a/tools/gn/substitution_type.h
+++ b/tools/gn/substitution_type.h
@@ -32,7 +32,7 @@ enum SubstitutionType {
SUBSTITUTION_SOURCE_OUT_DIR, // {{source_out_dir}}
// Valid for all compiler and linker tools. These depend on the target and
- // no not vary on a per-file basis.
+ // do not vary on a per-file basis.
SUBSTITUTION_LABEL, // {{label}}
SUBSTITUTION_LABEL_NAME, // {{label_name}}
SUBSTITUTION_ROOT_GEN_DIR, // {{root_gen_dir}}
@@ -117,6 +117,7 @@ bool IsValidCompilerOutputsSubstitution(SubstitutionType type);
bool IsValidLinkerSubstitution(SubstitutionType type);
bool IsValidLinkerOutputsSubstitution(SubstitutionType type);
bool IsValidCopySubstitution(SubstitutionType type);
+bool IsValidCompileXCassetsSubstitution(SubstitutionType type);
// Like the "IsValid..." version above but checks a list of types and sets a
// an error blaming the given source if the test fails.
« no previous file with comments | « tools/gn/ninja_target_writer.cc ('k') | tools/gn/substitution_type.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698