tools/gn/substitution_type.cc - Issue 1752033002: Add "create_bundle" target in order to support bundle with gn.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/gn/substitution_type.cc

Issue 1752033002: Add "create_bundle" target in order to support bundle with gn. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@gn-bundle-data

Patch Set: Add unit tests, address comments, update docs and format with clang-format Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/gn/substitution_type.cc

diff --git a/tools/gn/substitution_type.cc b/tools/gn/substitution_type.cc

index 93a32bd6e4c57264ac9d7e283e70ee997796083c..e1ea14de94799c84743d16d1cec660b442e3c457 100644

--- a/tools/gn/substitution_type.cc

+++ b/tools/gn/substitution_type.cc

@@ -208,6 +208,11 @@ bool IsValidCopySubstitution(SubstitutionType type) {

type == SUBSTITUTION_SOURCE;

}

+bool IsValidCompileXCassetsSubstitution(SubstitutionType type) {

+ return IsValidToolSubstitution(type) ||

+ type == SUBSTITUTION_LINKER_INPUTS;

bool EnsureValidSourcesSubstitutions(

const std::vector<SubstitutionType>& types,

const ParseNode* origin,

« no previous file with comments | « tools/gn/substitution_type.h ('k') | tools/gn/target.h » ('j') | no next file with comments »