Stub for conic section max curvature

Stub for conic section max curvature

BUG=skia:

Committed: http://code.google.com/p/skia/source/detail?r=13542

[humper, 2014-02-21 15:35:02]

PTAL, just stubbing the API and added some comments.

[reed1, 2014-02-21 17:00:04]

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp
File src/core/SkGeometry.cpp (right):

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp#newc...
src/core/SkGeometry.cpp:1170: //
http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.44.5740&rep=rep1&typ...
nit: 80-col

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp#newc...
src/core/SkGeometry.cpp:1202: // Take the parametric specification for the conic
(either X or Y) and return
This comment does not go with deriv_coeff, but perhaps there is no longer a
helper function that just returns the poly coeff for the conic?

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp#newc...
src/core/SkGeometry.cpp:1451: // Find the parameter value where the conic takes
on its maximum curvature.
Lets hoist this comment out to the header.

[humper, 2014-02-21 17:07:21]

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp
File src/core/SkGeometry.cpp (right):

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp#newc...
src/core/SkGeometry.cpp:1170: //
http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.44.5740&rep=rep1&typ...
On 2014/02/21 17:00:04, reed1 wrote:
> nit: 80-col

Done, and fixed a bunch of other 80 col issues in this file.

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp#newc...
src/core/SkGeometry.cpp:1202: // Take the parametric specification for the conic
(either X or Y) and return
On 2014/02/21 17:00:04, reed1 wrote:
> This comment does not go with deriv_coeff, but perhaps there is no longer a
> helper function that just returns the poly coeff for the conic?

Done.

https://codereview.chromium.org/175193003/diff/1/src/core/SkGeometry.cpp#newc...
src/core/SkGeometry.cpp:1451: // Find the parameter value where the conic takes
on its maximum curvature.
On 2014/02/21 17:00:04, reed1 wrote:
> Lets hoist this comment out to the header.

Done.

[reed1, 2014-02-21 17:09:41]

lgtm w/ nit

https://codereview.chromium.org/175193003/diff/50001/include/core/SkGeometry.h
File include/core/SkGeometry.h (right):

https://codereview.chromium.org/175193003/diff/50001/include/core/SkGeometry....
include/core/SkGeometry.h:259: // Find the parameter value where the conic takes
on its maximum curvature.
nit: /** style comments match others in (esp. public) headers, and are
digestible by doxygen.

[humper, 2014-02-21 17:14:28]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-02-21 17:14:33]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/175193003/110001

[commit-bot: I haz the power, 2014-02-21 18:23:50]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/175193003/110001

[commit-bot: I haz the power, 2014-02-21 18:23:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-02-21 18:23:51]

Failed to apply patch for include/core/SkGeometry.h:
While running git apply --index -p1;
  Created missing directory include/core.
  error: include/core/SkGeometry.h: does not exist in index

Patch:       include/core/SkGeometry.h
Index: include/core/SkGeometry.h
diff --git a/include/core/SkGeometry.h b/include/core/SkGeometry.h
index
d7836db735eaf749423c24a28a5efdad80ec4e41..119cfc68db54f31e328126a582ac2af34bae12fa
100644
--- a/include/core/SkGeometry.h
+++ b/include/core/SkGeometry.h
@@ -255,6 +255,15 @@ struct SkConic {
 
     void computeTightBounds(SkRect* bounds) const;
     void computeFastBounds(SkRect* bounds) const;
+
+    /** Find the parameter value where the conic takes on its maximum
curvature.
+     *
+     *  @param t   output scalar for max curvature.  Will be unchanged if
+     *             max curvature outside 0..1 range.
+     *
+     *  @return  true if max curvature found inside 0..1 range, false otherwise
+     */
+    bool findMaxCurvature(SkScalar* t) const;
 };
 
 #include "SkTemplates.h"

[humper, 2014-02-21 19:22:45]

The CQ bit was checked by humper@google.com

[commit-bot: I haz the power, 2014-02-21 19:22:55]

CQ is trying da patch. Follow status at
https://skia-tree-status.appspot.com/cq/humper@google.com/175193003/110001

[commit-bot: I haz the power, 2014-02-21 19:49:12]

Change committed as 13542