tools/external-reference-check.py - Issue 1751863002: [serializer] split up src/snapshot/serialize.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/external-reference-check.py

Issue 1751863002: [serializer] split up src/snapshot/serialize.* (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: fix build.gn Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: tools/external-reference-check.py

diff --git a/tools/external-reference-check.py b/tools/external-reference-check.py

index 287eca42515b9d909b646ada42722b0ab046c3be..550ca544b31d1daddf66168d7cf64569f5885933 100644

--- a/tools/external-reference-check.py

+++ b/tools/external-reference-check.py

@@ -8,7 +8,7 @@ import os

import sys

DECLARE_FILE = "src/assembler.h"

-REGISTER_FILE = "src/snapshot/serialize.cc"

+REGISTER_FILE = "src/snapshot/serializer-common.cc"

DECLARE_RE = re.compile("\s*static ExternalReference ([^(]+)\(")

REGISTER_RE = re.compile("\s*Add\(ExternalReference::([^(]+)\(")