content/browser/cache_storage/cache_storage_dispatcher_host.h - Issue 1751833002: Use string16 for cache_name in the back end of CacheStorage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cache_storage/cache_storage_dispatcher_host.h

Issue 1751833002: Use string16 for cache_name in the back end of CacheStorage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment and test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/cache_storage/cache_storage.proto ('k') | content/browser/cache_storage/cache_storage_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/cache_storage/cache_storage_dispatcher_host.h

diff --git a/content/browser/cache_storage/cache_storage_dispatcher_host.h b/content/browser/cache_storage/cache_storage_dispatcher_host.h

index 77435096db24ebe8a1ee9b4859e4322351ea4591..bdd71461d70156846a7eec6dee07983d56d2e03b 100644

--- a/content/browser/cache_storage/cache_storage_dispatcher_host.h

+++ b/content/browser/cache_storage/cache_storage_dispatcher_host.h

@@ -97,10 +97,11 @@ class CONTENT_EXPORT CacheStorageDispatcherHost : public BrowserMessageFilter {

int request_id,

bool deleted,

CacheStorageError error);

- void OnCacheStorageKeysCallback(int thread_id,

- int request_id,

- const std::vector<std::string>& strings,

- CacheStorageError error);

+ void OnCacheStorageKeysCallback(

+ int thread_id,

+ int request_id,

+ const std::vector<base::string16>& cache_names,

+ CacheStorageError error);

void OnCacheStorageMatchCallback(

int thread_id,

int request_id,