content/browser/cache_storage/cache_storage.proto - Issue 1751833002: Use string16 for cache_name in the back end of CacheStorage.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/cache_storage/cache_storage.proto

Issue 1751833002: Use string16 for cache_name in the back end of CacheStorage. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add comment and test Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/cache_storage/cache_storage.cc ('k') | content/browser/cache_storage/cache_storage_dispatcher_host.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/cache_storage/cache_storage.proto

diff --git a/content/browser/cache_storage/cache_storage.proto b/content/browser/cache_storage/cache_storage.proto

index 07a61700cff974fb1b38d568f576da0f15fbd8b3..0686126db4de95d0d3352f4974d04e1ef330cff7 100644

--- a/content/browser/cache_storage/cache_storage.proto

+++ b/content/browser/cache_storage/cache_storage.proto

@@ -12,6 +12,8 @@ message CacheStorageIndex {

message Cache {

required string name = 1;

optional string cache_dir = 2;

+ // To support UTF-16 properly, we use bytes type. See crbug.com/432746.

+ optional bytes name_utf16 = 3;

}

repeated Cache cache = 1;

optional string origin = 2;

« no previous file with comments | « content/browser/cache_storage/cache_storage.cc ('k') | content/browser/cache_storage/cache_storage_dispatcher_host.h » ('j') | no next file with comments »