Enable proprietary codecs and ffmpeg_branding=Chrome for Android.

Enable proprietary codecs and ffmpeg_branding=Chrome for Android.

Now that we have a unified media pipeline on Android, we need to
set these flags to ensure proprietary codec tests and such continue
to work properly.

Note: This CL will be rolled out in pieces; this one only enables
these flags on the Android Trial builder.

BUG=570762
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299035

[DaleCurtis, 2016-03-01 19:57:41]

dalecurtis@chromium.org changed reviewers:
+ jbudorick@chromium.org

[DaleCurtis, 2016-03-01 19:57:41]

Not sure how to run the tests here. Didn't see a README file. This does what
kbr@ did previously for desktop variants:
https://bugs.chromium.org/p/chromium/issues/detail?id=563847

I expect I need to update some expectations, but none of the tools I tried
randomly did so :( Tips?

[DaleCurtis, 2016-03-01 20:21:08]

dalecurtis@chromium.org changed reviewers:
+ dpranke@chromium.org

[DaleCurtis, 2016-03-01 20:21:08]

Okay found
https://www.chromium.org/developers/testing/gpu-recipe#TOC-Modifying-the-Reci...
and updated expectations per those docs. Let me know if I've missed something.

+dpranke for chromium*.py changes and expectation updates.

[jbudorick, 2016-03-01 20:25:23]

two issues:

 - we should try this on a limited set of Android bots before deploying it to
the main waterfall & CQ
 - this won't do anything for the bots that already use mb (i.e.,
chromium.android). those will need chrome_with_codecs added to their
configurations in //tools/mb/mb_config.pyl

[DaleCurtis, 2016-03-01 20:51:13]

Okay, can you suggest a set of bots then? I'm happy to do that in the next patch
set (or a separate one if you prefer)

[jbudorick, 2016-03-01 20:52:07]

On 2016/03/01 20:51:13, DaleCurtis wrote:
> Okay, can you suggest a set of bots then? I'm happy to do that in the next
patch
> set (or a separate one if you prefer)

Sure, I'd start with
https://build.chromium.org/p/chromium.fyi/builders/Android%20Tests%20(trial)(...
and the chromium.android bots.

[DaleCurtis, 2016-03-01 20:58:46]

Okay, reduced to just the trial builder for now.

[DaleCurtis, 2016-03-01 20:59:21]

Description was changed from

==========
Enable proprietary codecs and ffmpeg_branding=Chrome for Android.

Now that we have a unified media pipeline on Android, we need to
set these flags to ensure proprietary codec tests and such continue
to work properly.

BUG=570762
TEST=???
==========

to

==========
Enable proprietary codecs and ffmpeg_branding=Chrome for Android.

Now that we have a unified media pipeline on Android, we need to
set these flags to ensure proprietary codec tests and such continue
to work properly.

Note: This CL will be rolled out in pieces; this one only enables
these flags on the Android Trial builder.

BUG=570762
==========

[DaleCurtis, 2016-03-01 21:00:11]

On 2016/03/01 at 20:58:46, DaleCurtis wrote:
> Okay, reduced to just the trial builder for now.

By chromium.android bots did you mean the ones in chromium_android.py ?

[jbudorick, 2016-03-01 21:05:49]

On 2016/03/01 21:00:11, DaleCurtis wrote:
> On 2016/03/01 at 20:58:46, DaleCurtis wrote:
> > Okay, reduced to just the trial builder for now.
> 
> By chromium.android bots did you mean the ones in chromium_android.py ?

yes, but as mentioned, those will need to be updated via
//tools/mb/mb_config.pyl

[DaleCurtis, 2016-03-01 21:08:19]

Understood, already working on that CL (Note there are already configurations
enables this there in case that changes your answer about the limited roll out
here).

[DaleCurtis, 2016-03-01 21:08:50]

https://code.google.com/p/chromium/codesearch#chromium/src/tools/mb/mb_config...

[DaleCurtis, 2016-03-01 21:17:13]

https://codereview.chromium.org/1757573002 takes care of chromium.android

[Dirk Pranke, 2016-03-01 21:24:02]

lgtm

[jbudorick, 2016-03-01 21:29:55]

lgtm

[DaleCurtis, 2016-03-01 22:05:55]

The CQ bit was checked by dalecurtis@chromium.org

[commit-bot: I haz the power, 2016-03-01 22:06:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1751773003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1751773003/40001

[commit-bot: I haz the power, 2016-03-01 22:09:21]

Description was changed from

==========
Enable proprietary codecs and ffmpeg_branding=Chrome for Android.

Now that we have a unified media pipeline on Android, we need to
set these flags to ensure proprietary codec tests and such continue
to work properly.

Note: This CL will be rolled out in pieces; this one only enables
these flags on the Android Trial builder.

BUG=570762
==========

to

==========
Enable proprietary codecs and ffmpeg_branding=Chrome for Android.

Now that we have a unified media pipeline on Android, we need to
set these flags to ensure proprietary codec tests and such continue
to work properly.

Note: This CL will be rolled out in pieces; this one only enables
these flags on the Android Trial builder.

BUG=570762

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=299035
==========

[commit-bot: I haz the power, 2016-03-01 22:09:22]

Committed patchset #3 (id:40001) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=299035