Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Issue 1757573002: Convert chromium.android to use "chrome_with_codecs". (Closed)

Created:
4 years, 9 months ago by DaleCurtis
Modified:
4 years, 9 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert chromium.android to use "chrome_with_codecs". Now that we have a unified media pipeline on Android, we need to set these flags to ensure proprietary codec tests and such continue to work properly. Note: This will be rolled out in pieces, so not all configurations are updated right now. BUG=570762 Committed: https://crrev.com/614e80f5b1dca81d035e4f810e2205061509803c Cr-Commit-Position: refs/heads/master@{#378611}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M tools/mb/mb_config.pyl View 4 chunks +9 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (4 generated)
DaleCurtis
4 years, 9 months ago (2016-03-01 21:20:37 UTC) #3
DaleCurtis
Follow up to https://codereview.chromium.org/1751773003/
4 years, 9 months ago (2016-03-01 21:20:51 UTC) #4
Dirk Pranke
Do we plan to make ffmpeg_branding=="Chrome" by default on Android like proprietary_codecs is?
4 years, 9 months ago (2016-03-01 22:02:26 UTC) #5
DaleCurtis
I was actually planning to flip the default to false like other platforms, but am ...
4 years, 9 months ago (2016-03-01 22:05:28 UTC) #6
Dirk Pranke
lgtm as-is for now. I don't particularly like this solution (I don't like the bots ...
4 years, 9 months ago (2016-03-01 22:19:21 UTC) #7
DaleCurtis
Thanks for review. What metrics are we monitoring here (and on the other CL) to ...
4 years, 9 months ago (2016-03-01 22:21:06 UTC) #8
jbudorick
On 2016/03/01 22:21:06, DaleCurtis wrote: > Thanks for review. > > What metrics are we ...
4 years, 9 months ago (2016-03-01 22:21:55 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1757573002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1757573002/1
4 years, 9 months ago (2016-03-01 22:22:37 UTC) #11
DaleCurtis
Will you be watching this or is there a place you want me to look ...
4 years, 9 months ago (2016-03-01 22:22:41 UTC) #12
jbudorick
On 2016/03/01 22:22:41, DaleCurtis wrote: > Will you be watching this or is there a ...
4 years, 9 months ago (2016-03-01 23:15:02 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-01 23:50:22 UTC) #14
commit-bot: I haz the power
4 years, 9 months ago (2016-03-01 23:51:11 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/614e80f5b1dca81d035e4f810e2205061509803c
Cr-Commit-Position: refs/heads/master@{#378611}

Powered by Google App Engine
This is Rietveld 408576698