Remove implicit conversions and some cleanup

core/src/fpdfdoc/doc_form.cpp

Index: core/src/fpdfdoc/doc_form.cpp
diff --git a/core/src/fpdfdoc/doc_form.cpp b/core/src/fpdfdoc/doc_form.cpp
index 5e333ea02574332edc71e72332a7e8f9aa3dc6d9..64f2ae13039c46af4c0e1f7d018fcdb521ae9cb6 100644
--- a/core/src/fpdfdoc/doc_form.cpp
+++ b/core/src/fpdfdoc/doc_form.cpp
@@ -836,14 +836,14 @@ void CPDF_InterForm::RemoveFormFont(CFX_ByteString csNameTag) {
   m_bUpdated = TRUE;
   RemoveInterFormFont(m_pFormDict, csNameTag);
 }
+
 CPDF_DefaultAppearance CPDF_InterForm::GetDefaultAppearance() {
   CFX_ByteString csDA;

[Tom Sepez, 2016/03/01 17:53:35]

Do we have no-arg constructors for CPDF_DefaultAppearance that are equivalent to
the one-arg version called with an empty string?

If so, we can do
... {
  if (!m_pFormDict)
    return CPDF_DefautlAppearance();
  return CPDF_DefautlAppearance(m_pFormDict->GetStringBy("DA"));
}

[Wei Li, 2016/03/01 21:46:53]

Done.

-  if (!m_pFormDict) {
-    return csDA;
-  }
-  csDA = m_pFormDict->GetStringBy("DA");
-  return csDA;
+  if (m_pFormDict)
+    csDA = m_pFormDict->GetStringBy("DA");
+  return CPDF_DefaultAppearance(csDA);
 }
+
 CPDF_Font* CPDF_InterForm::GetDefaultFormFont() {
   return GetDefaultInterFormFont(m_pFormDict, m_pDocument);
 }