Remove implicit conversions and some cleanup

core/src/fpdfdoc/doc_form.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "core/include/fpdfdoc/fpdf_doc.h"
 #include "core/src/fpdfdoc/doc_utils.h"
 #include "third_party/base/stl_util.h"
 
@@ skipping 818 matching lines @@
   return AddNativeInterFormFont(m_pFormDict, m_pDocument, csNameTag);
 }
 void CPDF_InterForm::RemoveFormFont(const CPDF_Font* pFont) {
   m_bUpdated = TRUE;
   RemoveInterFormFont(m_pFormDict, pFont);
 }
 void CPDF_InterForm::RemoveFormFont(CFX_ByteString csNameTag) {
   m_bUpdated = TRUE;
   RemoveInterFormFont(m_pFormDict, csNameTag);
 }
+
 CPDF_DefaultAppearance CPDF_InterForm::GetDefaultAppearance() {
   CFX_ByteString csDA;

[Tom Sepez, 2016/03/01 17:53:35]

Do we have no-arg constructors for CPDF_DefaultAppearance that are equivalent to
the one-arg version called with an empty string?

If so, we can do
... {
  if (!m_pFormDict)
    return CPDF_DefautlAppearance();
  return CPDF_DefautlAppearance(m_pFormDict->GetStringBy("DA"));
}

[Wei Li, 2016/03/01 21:46:53]

Done.

-  if (!m_pFormDict) {
-    return csDA;
-  }
-  csDA = m_pFormDict->GetStringBy("DA");
-  return csDA;
+  if (m_pFormDict)
+    csDA = m_pFormDict->GetStringBy("DA");
+  return CPDF_DefaultAppearance(csDA);
 }
+
 CPDF_Font* CPDF_InterForm::GetDefaultFormFont() {
   return GetDefaultInterFormFont(m_pFormDict, m_pDocument);
 }
 int CPDF_InterForm::GetFormAlignment() {
   return m_pFormDict ? m_pFormDict->GetIntegerBy("Q", 0) : 0;
 }
 
 bool CPDF_InterForm::ResetForm(const std::vector<CPDF_FormField*>& fields,
                                bool bIncludeOrExclude,
                                bool bNotify) {
@@ skipping 350 matching lines @@
     FDF_ImportField(pField, L"", bNotify);
   }
   if (bNotify && m_pFormNotify) {
     m_pFormNotify->AfterFormImportData(this);
   }
   return TRUE;
 }
 void CPDF_InterForm::SetFormNotify(const CPDF_FormNotify* pNotify) {
   m_pFormNotify = (CPDF_FormNotify*)pNotify;
 }