Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1751593002:
Disables CertVerifyProcTest.CybertrustGTERoot. (Closed)
DescriptionDisables CertVerifyProcTest.CybertrustGTERoot.
Failures on multiple bots, e.g.
https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests%20%281%29/builds/12559/steps/net_unittests%20on%20Mac-10.9/logs/CertVerifyProcTest.CybertrustGTERoot
BUG=590868
NOTRY=true
NOPRESUBMIT=true
Committed: https://crrev.com/8f9cd66a841a603275f5137c0d59b093654a054d
Cr-Commit-Position: refs/heads/master@{#378311}
Patch Set 1 #
Total comments: 2
Messages
Total messages: 20 (9 generated)
The CQ bit was checked by nektar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751593002/1
The CQ bit was unchecked by commit-bot@chromium.org
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full committers or once the patch has received an L-G-T-M from a full committer. Even if an L-G-T-M may have been provided, it was from a non-committer, _not_ a full super star committer. See http://www.chromium.org/getting-involved/become-a-committer Note that this has nothing to do with OWNERS files.
nektar@chromium.org changed reviewers: + dschuyler@chromium.org
Needed to re-enable multiple Mac bots.
https://codereview.chromium.org/1751593002/diff/1/net/cert/cert_verify_proc_u... File net/cert/cert_verify_proc_unittest.cc (right): https://codereview.chromium.org/1751593002/diff/1/net/cert/cert_verify_proc_u... net/cert/cert_verify_proc_unittest.cc:1179: TEST_F(CertVerifyProcTest, DISABLED_CybertrustGTERoot) { If this is Mac only, it should be ifdef'd for disabling on mac. See: https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/ha...
lgtm https://codereview.chromium.org/1751593002/diff/1/net/cert/cert_verify_proc_u... File net/cert/cert_verify_proc_unittest.cc (right): https://codereview.chromium.org/1751593002/diff/1/net/cert/cert_verify_proc_u... net/cert/cert_verify_proc_unittest.cc:1179: TEST_F(CertVerifyProcTest, DISABLED_CybertrustGTERoot) { On 2016/02/29 22:03:53, dschuyler wrote: > If this is Mac only, it should be ifdef'd for disabling on mac. > See: > https://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium/ha... My mistake, this is already in a ifdef.
The CQ bit was checked by nektar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751593002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
nektar@chromium.org changed reviewers: + davidben@chromium.org, gavinp@chromium.org
Can one of the owners LGTM please?
Description was changed from ========== Disables CertVerifyProcTest.CybertrustGTERoot. Failures on multiple bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests... BUG=590868 ========== to ========== Disables CertVerifyProcTest.CybertrustGTERoot. Failures on multiple bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests... BUG=590868 NOTRY=true NOPRESUBMIT=true ==========
The CQ bit was checked by nektar@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1751593002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1751593002/1
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Disables CertVerifyProcTest.CybertrustGTERoot. Failures on multiple bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests... BUG=590868 NOTRY=true NOPRESUBMIT=true ========== to ========== Disables CertVerifyProcTest.CybertrustGTERoot. Failures on multiple bots, e.g. https://build.chromium.org/p/chromium.memory/builders/Mac%20ASan%2064%20Tests... BUG=590868 NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/8f9cd66a841a603275f5137c0d59b093654a054d Cr-Commit-Position: refs/heads/master@{#378311} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8f9cd66a841a603275f5137c0d59b093654a054d Cr-Commit-Position: refs/heads/master@{#378311} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
