Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Side by Side Diff: net/cert/cert_verify_proc_unittest.cc

Issue 1751593002: Disables CertVerifyProcTest.CybertrustGTERoot. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/cert/cert_verify_proc.h" 5 #include "net/cert/cert_verify_proc.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "base/callback_helpers.h" 9 #include "base/callback_helpers.h"
10 #include "base/files/file_path.h" 10 #include "base/files/file_path.h"
(...skipping 1158 matching lines...) Expand 10 before | Expand all | Expand 10 after
1169 } 1169 }
1170 1170
1171 #if defined(OS_MACOSX) && !defined(OS_IOS) 1171 #if defined(OS_MACOSX) && !defined(OS_IOS)
1172 // Tests that, on OS X, issues with a cross-certified Baltimore CyberTrust 1172 // Tests that, on OS X, issues with a cross-certified Baltimore CyberTrust
1173 // Root can be successfully worked around once Apple completes removing the 1173 // Root can be successfully worked around once Apple completes removing the
1174 // older GTE CyberTrust Root from its trusted root store. 1174 // older GTE CyberTrust Root from its trusted root store.
1175 // 1175 //
1176 // The issue is caused by servers supplying the cross-certified intermediate 1176 // The issue is caused by servers supplying the cross-certified intermediate
1177 // (necessary for certain mobile platforms), which OS X does not recognize 1177 // (necessary for certain mobile platforms), which OS X does not recognize
1178 // as already existing within its trust store. 1178 // as already existing within its trust store.
1179 TEST_F(CertVerifyProcTest, CybertrustGTERoot) { 1179 TEST_F(CertVerifyProcTest, DISABLED_CybertrustGTERoot) {
dschuyler 2016/02/29 22:03:53 If this is Mac only, it should be ifdef'd for disa
dschuyler 2016/02/29 22:04:42 My mistake, this is already in a ifdef.
1180 CertificateList certs = CreateCertificateListFromFile( 1180 CertificateList certs = CreateCertificateListFromFile(
1181 GetTestCertsDirectory(), 1181 GetTestCertsDirectory(),
1182 "cybertrust_omniroot_chain.pem", 1182 "cybertrust_omniroot_chain.pem",
1183 X509Certificate::FORMAT_PEM_CERT_SEQUENCE); 1183 X509Certificate::FORMAT_PEM_CERT_SEQUENCE);
1184 ASSERT_EQ(2U, certs.size()); 1184 ASSERT_EQ(2U, certs.size());
1185 1185
1186 X509Certificate::OSCertHandles intermediates; 1186 X509Certificate::OSCertHandles intermediates;
1187 intermediates.push_back(certs[1]->os_cert_handle()); 1187 intermediates.push_back(certs[1]->os_cert_handle());
1188 1188
1189 scoped_refptr<X509Certificate> cybertrust_basic = 1189 scoped_refptr<X509Certificate> cybertrust_basic =
(...skipping 763 matching lines...) Expand 10 before | Expand all | Expand 10 after
1953 int flags = 0; 1953 int flags = 0;
1954 CertVerifyResult verify_result; 1954 CertVerifyResult verify_result;
1955 int error = Verify(cert.get(), "127.0.0.1", flags, NULL, empty_cert_list_, 1955 int error = Verify(cert.get(), "127.0.0.1", flags, NULL, empty_cert_list_,
1956 &verify_result); 1956 &verify_result);
1957 EXPECT_EQ(ERR_CERT_INVALID, error); 1957 EXPECT_EQ(ERR_CERT_INVALID, error);
1958 EXPECT_EQ(CERT_STATUS_INVALID, verify_result.cert_status); 1958 EXPECT_EQ(CERT_STATUS_INVALID, verify_result.cert_status);
1959 } 1959 }
1960 #endif // defined(OS_MACOSX) && !defined(OS_IOS) 1960 #endif // defined(OS_MACOSX) && !defined(OS_IOS)
1961 1961
1962 } // namespace net 1962 } // namespace net
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698