[MD settings] change ClearBrowsingData from a sub-page to a dialog

chrome/browser/resources/settings/privacy_page/privacy_page.html

Index: chrome/browser/resources/settings/privacy_page/privacy_page.html
diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.html b/chrome/browser/resources/settings/privacy_page/privacy_page.html
index 2894d39a64709b723b44d4606791f8e7c16cbe0e..0096961578b1dbb7e3d30be167e910009543b383 100644
--- a/chrome/browser/resources/settings/privacy_page/privacy_page.html
+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.html
@@ -19,6 +19,8 @@
     <settings-animated-pages id="pages" current-route="{{currentRoute}}"
         section="privacy">
       <neon-animatable id="main">
+        <settings-clear-browsing-data-page prefs="{{prefs}}">

[dpapad, 2016/03/09 20:13:24]

From a performance standpoint this dialog is always created even if the user
never clicks on "clear browsing data". This is unnecessary. I have addressed
this for several other dialogs with a dom-if. If you feel this should be
addressed, it is OK to do it in separate CL. For an example you can look  at
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res....

[dschuyler, 2016/03/09 22:15:16]

Let's do the separate CL.

+        </settings-clear-browsing-data-page>
         <div class="settings-box block first">
           <p class="privacy-explanation"
               i18n-values=".innerHTML:improveBrowsingExperience">
@@ -211,12 +213,6 @@
             category-selected="{{categorySelected}}">
         </site-details>
       </neon-animatable>
-      <neon-animatable id="clear-browsing-data">
-        <settings-subheader i18n-values="page-title:clearBrowsingData">
-        </settings-subheader>
-        <settings-clear-browsing-data-page prefs="{{prefs}}">
-        </settings-clear-browsing-data-page>
-      </neon-animatable>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>