[MD settings] change ClearBrowsingData from a sub-page to a dialog

chrome/browser/resources/settings/privacy_page/privacy_page.html

 <link rel="import" href="chrome://resources/polymer/v1_0/polymer/polymer.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/iron-flex-layout/classes/iron-flex-layout.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/neon-animation/neon-animatable.html">
 <link rel="import" href="chrome://resources/polymer/v1_0/paper-button/paper-button.html">
 <link rel="import" href="chrome://md-settings/certificate_manager_page/certificate_manager_page.html">
 <link rel="import" href="chrome://md-settings/clear_browsing_data_page/clear_browsing_data_page.html">
 <link rel="import" href="chrome://md-settings/controls/settings_checkbox.html">
 <link rel="import" href="chrome://md-settings/settings_page/settings_animated_pages.html">
 <link rel="import" href="chrome://md-settings/settings_page/settings_subheader.html">
 <link rel="import" href="chrome://md-settings/settings_shared_css.html">
 <link rel="import" href="chrome://md-settings/site_settings/all_sites.html">
 <link rel="import" href="chrome://md-settings/site_settings/constants.html">
 <link rel="import" href="chrome://md-settings/site_settings_page/site_settings_page.html">
 
 <dom-module id="settings-privacy-page">
   <link rel="import" type="css" href="privacy_page.css">
   <template>
     <style include="settings-shared"></style>
     <settings-animated-pages id="pages" current-route="{{currentRoute}}"
         section="privacy">
       <neon-animatable id="main">
+        <settings-clear-browsing-data-page prefs="{{prefs}}">

[dpapad, 2016/03/09 20:13:24]

From a performance standpoint this dialog is always created even if the user
never clicks on "clear browsing data". This is unnecessary. I have addressed
this for several other dialogs with a dom-if. If you feel this should be
addressed, it is OK to do it in separate CL. For an example you can look  at
https://code.google.com/p/chromium/codesearch#chromium/src/chrome/browser/res....

[dschuyler, 2016/03/09 22:15:16]

Let's do the separate CL.

+        </settings-clear-browsing-data-page>
         <div class="settings-box block first">
           <p class="privacy-explanation"
               i18n-values=".innerHTML:improveBrowsingExperience">
           </p>
           <settings-checkbox
               pref="{{prefs.alternate_error_pages.enabled}}"
               i18n-values="label:linkDoctorPref">
           </settings-checkbox>
           <settings-checkbox
               pref="{{prefs.search.suggest_enabled}}"
@@ skipping 172 matching lines @@
             category="{{ContentSettingsTypes.POPUPS}}">
         </site-settings-category>
       </neon-animatable>
 
       <neon-animatable id="site-details">
         <site-details prefs="{{prefs}}" origin="{{originSelected}}"
             current-route="{{currentRoute}}"
             category-selected="{{categorySelected}}">
         </site-details>
       </neon-animatable>
-      <neon-animatable id="clear-browsing-data">
-        <settings-subheader i18n-values="page-title:clearBrowsingData">
-        </settings-subheader>
-        <settings-clear-browsing-data-page prefs="{{prefs}}">
-        </settings-clear-browsing-data-page>
-      </neon-animatable>
     </settings-animated-pages>
   </template>
   <script src="privacy_page.js"></script>
 </dom-module>