chrome/browser/resources/settings/privacy_page/privacy_page.js - Issue 1750873002: [MD settings] change ClearBrowsingData from a sub-page to a dialog

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/privacy_page/privacy_page.js

Issue 1750873002: [MD settings] change ClearBrowsingData from a sub-page to a dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: clean up Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js ('K') | « chrome/browser/resources/settings/privacy_page/privacy_page.html ('k') | chrome/browser/resources/settings/settings_dialog_css.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/privacy_page/privacy_page.js

diff --git a/chrome/browser/resources/settings/privacy_page/privacy_page.js b/chrome/browser/resources/settings/privacy_page/privacy_page.js

index b9ed9924a36b211475c6683b3309532419002985..4c70b1012b801c82468f3d2dca409335ae9cbb1e 100644

--- a/chrome/browser/resources/settings/privacy_page/privacy_page.js

+++ b/chrome/browser/resources/settings/privacy_page/privacy_page.js

@@ -55,6 +55,7 @@ Polymer({

/** @private */

onClearBrowsingDataTap_: function() {

- this.$.pages.setSubpageChain(['clear-browsing-data']);

+ this.$.pages.querySelector('settings-clear-browsing-data-page').$

+ .clearBrowsingDataDialog.open();

michaelpg 2016/03/02 23:19:37 eek, can we add a public function instead of using

dschuyler 2016/03/03 02:05:03 Done.

});