Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(632)

Unified Diff: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js

Issue 1750873002: [MD settings] change ClearBrowsingData from a sub-page to a dialog (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: clean up Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
diff --git a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
index 5a9b14c2c61c0bdc9027ebcaaa5f5d433c7240e6..4e297a65bd75f15aa8a692122f6b9fdde90f3802 100644
--- a/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
+++ b/chrome/browser/resources/settings/clear_browsing_data_page/clear_browsing_data_page.js
@@ -16,7 +16,7 @@
* </iron-animated-pages>
*
* @group Chrome Settings Elements
- * @element settings-privacy-page
+ * @element settings-clear-browsing-data-page
*/
Polymer({
is: 'settings-clear-browsing-data-page',
@@ -96,6 +96,11 @@ Polymer({
},
/** @private */
+ onCancelTap_: function() {
+ this.$.clearBrowsingDataDialog.close();
+ },
+
+ /** @private */
onPerformClearBrowsingDataTap_: function() {
this.$.clearDataButton.disabled = true;
michaelpg 2016/03/02 23:19:37 does this close the dialog? (shouldn't it?)
dschuyler 2016/03/03 02:05:03 Initially, we had a sub-page that would disable th
chrome.send('performClearBrowserData');

Powered by Google App Engine
This is Rietveld 408576698