Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1211)

Unified Diff: content/renderer/render_frame_impl_browsertest.cc

Issue 1750863002: Revert of Separate RenderView from RenderWidget, part 1: inheritance. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@renderwidgettest
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/render_frame_impl_browsertest.cc
diff --git a/content/renderer/render_frame_impl_browsertest.cc b/content/renderer/render_frame_impl_browsertest.cc
index 79b647d5347908ed6b6466906b2ab7c1936bcc01..00456c9a6a09036be6456d2416b701698cd198a0 100644
--- a/content/renderer/render_frame_impl_browsertest.cc
+++ b/content/renderer/render_frame_impl_browsertest.cc
@@ -125,7 +125,20 @@
// RenderWidget.
TEST_F(RenderFrameImplTest, MAYBE_SubframeWidget) {
EXPECT_TRUE(frame_widget());
- EXPECT_NE(frame_widget(), view_->GetWidget());
+ // We can't convert to RenderWidget* directly, because
+ // it and RenderView are two unrelated base classes
+ // of RenderViewImpl. If a class has multiple base classes,
+ // each base class pointer will be distinct, and direct casts
+ // between unrelated base classes are undefined, even if they share
+ // a common derived class. The compiler has no way in general of
+ // determining the displacement between the two classes, so these
+ // types of casts cannot be implemented in a type safe way.
+ // To overcome this, we make two legal static casts:
+ // first, downcast from RenderView* to RenderViewImpl*,
+ // then upcast from RenderViewImpl* to RenderWidget*.
+ EXPECT_NE(frame_widget(),
+ static_cast<content::RenderWidget*>(
+ static_cast<content::RenderViewImpl*>((view_))));
}
// Verify a subframe RenderWidget properly processes its viewport being
« no previous file with comments | « content/renderer/render_frame_impl.cc ('k') | content/renderer/render_frame_proxy.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698