Disabling calls to TexParameteri when the values do not exist on ES2.

Disabling calls to TexParameteri when the values do not exist on ES2.

BUG=590804
GOLD_TRYBOT_URL= https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&issue=1750833003

Committed: https://skia.googlesource.com/skia/+/09bd2c09b6b36737df289fdb5fa38c280162cbb8

[cblume, 2016-03-01 09:56:06]

Description was changed from

==========
Disabling calls to TexParameteri when the values do not exist on ES2.

BUG=590804
==========

to

==========
Disabling calls to TexParameteri when the values do not exist on ES2.

BUG=590804
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

[cblume, 2016-03-01 09:56:37]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 09:56:48]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750833003/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750833003/1

[commit-bot: I haz the power, 2016-03-01 09:56:48]

Note for Reviewers:
The CQ is waiting for an approval.
If you believe that the CL is not ready yet, or if you would like to L-G-T-M
with comments then please uncheck the CQ checkbox.

Waiting for LGTM from valid reviewer(s) till 2016-03-01 15:56 UTC

[cblume, 2016-03-01 09:57:22]

cblume@chromium.org changed reviewers:
+ bsalomon@google.com

[bsalomon, 2016-03-01 14:21:16]

https://codereview.chromium.org/1750833003/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1750833003/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:3348: if (this->glStandard() != kGLES_GrGLStandard &&
this->glVersion() != GR_GL_VER(2,0)) {
Can we make this a cap? Maybe mipMapLevelAndLodControlSupport()?

[commit-bot: I haz the power, 2016-03-01 15:56:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 15:56:01]

Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[cblume, 2016-03-01 21:31:35]

The CQ bit was checked by cblume@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-03-01 21:31:45]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750833003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750833003/20001

[commit-bot: I haz the power, 2016-03-01 21:31:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-03-01 21:31:47]

Dry run: No LGTM from a valid reviewer yet. Please ask for an LGTM from a
full Skia committer

[cblume, 2016-03-01 21:36:51]

https://codereview.chromium.org/1750833003/diff/1/src/gpu/gl/GrGLGpu.cpp
File src/gpu/gl/GrGLGpu.cpp (right):

https://codereview.chromium.org/1750833003/diff/1/src/gpu/gl/GrGLGpu.cpp#newc...
src/gpu/gl/GrGLGpu.cpp:3348: if (this->glStandard() != kGLES_GrGLStandard &&
this->glVersion() != GR_GL_VER(2,0)) {
On 2016/03/01 14:21:16, bsalomon wrote:
> Can we make this a cap? Maybe mipMapLevelAndLodControlSupport()?

Done.

[bsalomon, 2016-03-01 21:48:37]

https://codereview.chromium.org/1750833003/diff/20001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1750833003/diff/20001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:251: fMipMapLevelAndLodControlSupport = true;
Sorry should have asked this earlier, but does this really go all the way back?
OpenGL 2.1 is sort of our minimum requirement on the desktop side.

[cblume, 2016-03-01 21:53:02]

https://codereview.chromium.org/1750833003/diff/20001/src/gpu/gl/GrGLCaps.cpp
File src/gpu/gl/GrGLCaps.cpp (right):

https://codereview.chromium.org/1750833003/diff/20001/src/gpu/gl/GrGLCaps.cpp...
src/gpu/gl/GrGLCaps.cpp:251: fMipMapLevelAndLodControlSupport = true;
On 2016/03/01 21:48:37, bsalomon wrote:
> Sorry should have asked this earlier, but does this really go all the way
back?
> OpenGL 2.1 is sort of our minimum requirement on the desktop side.

OpenGL 2.1 supports this, yes.
If you go to the OpenGL 2.1 docs (https://www.opengl.org/sdk/docs/man2/) and
look under glTexParameter
(https://www.opengl.org/sdk/docs/man2/xhtml/glTexParameter.xml) you'll see
"GL_TEXTURE_MIN_LOD, GL_TEXTURE_MAX_LOD, GL_TEXTURE_BASE_LEVEL,
GL_TEXTURE_MAX_LEVEL,"

[bsalomon, 2016-03-01 22:06:07]

On 2016/03/01 21:53:02, cblume wrote:
> https://codereview.chromium.org/1750833003/diff/20001/src/gpu/gl/GrGLCaps.cpp
> File src/gpu/gl/GrGLCaps.cpp (right):
> 
>
https://codereview.chromium.org/1750833003/diff/20001/src/gpu/gl/GrGLCaps.cpp...
> src/gpu/gl/GrGLCaps.cpp:251: fMipMapLevelAndLodControlSupport = true;
> On 2016/03/01 21:48:37, bsalomon wrote:
> > Sorry should have asked this earlier, but does this really go all the way
> back?
> > OpenGL 2.1 is sort of our minimum requirement on the desktop side.
> 
> OpenGL 2.1 supports this, yes.
> If you go to the OpenGL 2.1 docs (https://www.opengl.org/sdk/docs/man2/) and
> look under glTexParameter
> (https://www.opengl.org/sdk/docs/man2/xhtml/glTexParameter.xml) you'll see
> "GL_TEXTURE_MIN_LOD, GL_TEXTURE_MAX_LOD, GL_TEXTURE_BASE_LEVEL,
> GL_TEXTURE_MAX_LEVEL,"

lgtm

[cblume, 2016-03-01 22:07:10]

The CQ bit was checked by cblume@chromium.org

[commit-bot: I haz the power, 2016-03-01 22:07:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1750833003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1750833003/20001

[commit-bot: I haz the power, 2016-03-01 22:08:30]

Description was changed from

==========
Disabling calls to TexParameteri when the values do not exist on ES2.

BUG=590804
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...
==========

to

==========
Disabling calls to TexParameteri when the values do not exist on ES2.

BUG=590804
GOLD_TRYBOT_URL=
https://gold.skia.org/search2?unt=true&query=source_type%3Dgm&master=false&is...

Committed:
https://skia.googlesource.com/skia/+/09bd2c09b6b36737df289fdb5fa38c280162cbb8
==========

[commit-bot: I haz the power, 2016-03-01 22:08:31]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/09bd2c09b6b36737df289fdb5fa38c280162cbb8