Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(681)

Unified Diff: src/gpu/gl/GrGLCaps.cpp

Issue 1750833003: Disabling calls to TexParameteri when the values do not exist on ES2. (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Making the check for mipmap lod part of caps. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/gpu/gl/GrGLCaps.h ('k') | src/gpu/gl/GrGLGpu.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/gl/GrGLCaps.cpp
diff --git a/src/gpu/gl/GrGLCaps.cpp b/src/gpu/gl/GrGLCaps.cpp
index 792f3ed5ba63555bb4305c247531ba6790a571e3..a04c0e728e1c20e7ff9b1438f48b4ecd51d2d786 100644
--- a/src/gpu/gl/GrGLCaps.cpp
+++ b/src/gpu/gl/GrGLCaps.cpp
@@ -52,6 +52,7 @@ GrGLCaps::GrGLCaps(const GrContextOptions& contextOptions,
fSRGBWriteControl = false;
fRGBA8888PixelsOpsAreSlow = false;
fPartialFBOReadIsSlow = false;
+ fMipMapLevelAndLodControlSupport = false;
fBlitFramebufferSupport = kNone_BlitFramebufferSupport;
@@ -246,6 +247,14 @@ void GrGLCaps::init(const GrContextOptions& contextOptions,
}
}
+ if (kGL_GrGLStandard == standard) {
+ fMipMapLevelAndLodControlSupport = true;
bsalomon 2016/03/01 21:48:37 Sorry should have asked this earlier, but does thi
cblume 2016/03/01 21:53:01 OpenGL 2.1 supports this, yes. If you go to the Op
+ } else if (kGLES_GrGLStandard == standard) {
+ if (version >= GR_GL_VER(3,0)) {
+ fMipMapLevelAndLodControlSupport = true;
+ }
+ }
+
#ifdef SK_BUILD_FOR_WIN
// We're assuming that on Windows Chromium we're using ANGLE.
bool isANGLE = kANGLE_GrGLDriver == ctxInfo.driver() ||
« no previous file with comments | « src/gpu/gl/GrGLCaps.h ('k') | src/gpu/gl/GrGLGpu.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698