Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: sdk/lib/web_gl/dart2js/web_gl_dart2js.dart

Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/web_audio/dartium/web_audio_dartium.dart ('k') | sdk/lib/web_gl/dartium/web_gl_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/web_gl/dart2js/web_gl_dart2js.dart
diff --git a/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart b/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart
index 0a35ac158e73d3cb6ffbf907f4e59e2a2ce21f9b..1cad109985de1f1f282bc0b9d896b8e872a3bce6 100644
--- a/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart
+++ b/sdk/lib/web_gl/dart2js/web_gl_dart2js.dart
@@ -326,8 +326,6 @@ const int ZERO = RenderingContext.ZERO;
@DomName('WebGLActiveInfo')
@Unstable
class ActiveInfo native "WebGLActiveInfo" {
- // To suppress missing implicit constructor warnings.
- factory ActiveInfo._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLActiveInfo.name')
@DocsEditable
@@ -350,8 +348,6 @@ class ActiveInfo native "WebGLActiveInfo" {
@DomName('WebGLBuffer')
@Unstable
class Buffer native "WebGLBuffer" {
- // To suppress missing implicit constructor warnings.
- factory Buffer._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -363,8 +359,6 @@ class Buffer native "WebGLBuffer" {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_atc/
@Experimental
class CompressedTextureAtc native "WebGLCompressedTextureATC" {
- // To suppress missing implicit constructor warnings.
- factory CompressedTextureAtc._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLCompressedTextureATC.COMPRESSED_RGBA_ATC_EXPLICIT_ALPHA_WEBGL')
@DocsEditable
@@ -388,8 +382,6 @@ class CompressedTextureAtc native "WebGLCompressedTextureATC" {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_pvrtc/
@Experimental // experimental
class CompressedTexturePvrtc native "WebGLCompressedTexturePVRTC" {
- // To suppress missing implicit constructor warnings.
- factory CompressedTexturePvrtc._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLCompressedTexturePVRTC.COMPRESSED_RGBA_PVRTC_2BPPV1_IMG')
@DocsEditable
@@ -417,8 +409,6 @@ class CompressedTexturePvrtc native "WebGLCompressedTexturePVRTC" {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/
@Experimental // experimental
class CompressedTextureS3TC native "WebGLCompressedTextureS3TC" {
- // To suppress missing implicit constructor warnings.
- factory CompressedTextureS3TC._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLCompressedTextureS3TC.COMPRESSED_RGBA_S3TC_DXT1_EXT')
@DocsEditable
@@ -445,8 +435,6 @@ class CompressedTextureS3TC native "WebGLCompressedTextureS3TC" {
@DomName('WebGLContextAttributes')
@Unstable
class ContextAttributes native "WebGLContextAttributes" {
- // To suppress missing implicit constructor warnings.
- factory ContextAttributes._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLContextAttributes.alpha')
@DocsEditable
@@ -481,8 +469,6 @@ class ContextAttributes native "WebGLContextAttributes" {
@DomName('WebGLContextEvent')
@Unstable
class ContextEvent extends Event native "WebGLContextEvent" {
- // To suppress missing implicit constructor warnings.
- factory ContextEvent._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLContextEvent.statusMessage')
@DocsEditable
@@ -498,8 +484,6 @@ class ContextEvent extends Event native "WebGLContextEvent" {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_debug_renderer_info/
@Experimental // experimental
class DebugRendererInfo native "WebGLDebugRendererInfo" {
- // To suppress missing implicit constructor warnings.
- factory DebugRendererInfo._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLDebugRendererInfo.UNMASKED_RENDERER_WEBGL')
@DocsEditable
@@ -519,8 +503,6 @@ class DebugRendererInfo native "WebGLDebugRendererInfo" {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_debug_shaders/
@Experimental // experimental
class DebugShaders native "WebGLDebugShaders" {
- // To suppress missing implicit constructor warnings.
- factory DebugShaders._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLDebugShaders.getTranslatedShaderSource')
@DocsEditable
@@ -536,8 +518,6 @@ class DebugShaders native "WebGLDebugShaders" {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/
@Experimental // experimental
class DepthTexture native "WebGLDepthTexture" {
- // To suppress missing implicit constructor warnings.
- factory DepthTexture._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLDepthTexture.UNSIGNED_INT_24_8_WEBGL')
@DocsEditable
@@ -553,8 +533,6 @@ class DepthTexture native "WebGLDepthTexture" {
// http://www.khronos.org/registry/webgl/specs/latest/
@Experimental // stable
class ExtDrawBuffers native "EXTDrawBuffers" {
- // To suppress missing implicit constructor warnings.
- factory ExtDrawBuffers._() { throw new UnsupportedError("Not supported"); }
@DomName('EXTDrawBuffers.COLOR_ATTACHMENT0_EXT')
@DocsEditable
@@ -702,8 +680,6 @@ class ExtDrawBuffers native "EXTDrawBuffers" {
// http://www.khronos.org/registry/webgl/extensions/EXT_frag_depth/
@Experimental
class ExtFragDepth native "EXTFragDepth" {
- // To suppress missing implicit constructor warnings.
- factory ExtFragDepth._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -715,8 +691,6 @@ class ExtFragDepth native "EXTFragDepth" {
// http://www.khronos.org/registry/webgl/extensions/EXT_texture_filter_anisotropic/
@Experimental
class ExtTextureFilterAnisotropic native "EXTTextureFilterAnisotropic" {
- // To suppress missing implicit constructor warnings.
- factory ExtTextureFilterAnisotropic._() { throw new UnsupportedError("Not supported"); }
@DomName('EXTTextureFilterAnisotropic.MAX_TEXTURE_MAX_ANISOTROPY_EXT')
@DocsEditable
@@ -735,8 +709,6 @@ class ExtTextureFilterAnisotropic native "EXTTextureFilterAnisotropic" {
@DomName('WebGLFramebuffer')
@Unstable
class Framebuffer native "WebGLFramebuffer" {
- // To suppress missing implicit constructor warnings.
- factory Framebuffer._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -748,8 +720,6 @@ class Framebuffer native "WebGLFramebuffer" {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/
@Experimental
class LoseContext native "WebGLLoseContext" {
- // To suppress missing implicit constructor warnings.
- factory LoseContext._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLLoseContext.loseContext')
@DocsEditable
@@ -769,8 +739,6 @@ class LoseContext native "WebGLLoseContext" {
// http://www.khronos.org/registry/webgl/extensions/OES_element_index_uint/
@Experimental // experimental
class OesElementIndexUint native "OESElementIndexUint" {
- // To suppress missing implicit constructor warnings.
- factory OesElementIndexUint._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -782,8 +750,6 @@ class OesElementIndexUint native "OESElementIndexUint" {
// http://www.khronos.org/registry/webgl/extensions/OES_standard_derivatives/
@Experimental // experimental
class OesStandardDerivatives native "OESStandardDerivatives" {
- // To suppress missing implicit constructor warnings.
- factory OesStandardDerivatives._() { throw new UnsupportedError("Not supported"); }
@DomName('OESStandardDerivatives.FRAGMENT_SHADER_DERIVATIVE_HINT_OES')
@DocsEditable
@@ -799,8 +765,6 @@ class OesStandardDerivatives native "OESStandardDerivatives" {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_float/
@Experimental // experimental
class OesTextureFloat native "OESTextureFloat" {
- // To suppress missing implicit constructor warnings.
- factory OesTextureFloat._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -812,8 +776,6 @@ class OesTextureFloat native "OESTextureFloat" {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_float_linear/
@Experimental
class OesTextureFloatLinear native "OESTextureFloatLinear" {
- // To suppress missing implicit constructor warnings.
- factory OesTextureFloatLinear._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -825,8 +787,6 @@ class OesTextureFloatLinear native "OESTextureFloatLinear" {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float/
@Experimental // experimental
class OesTextureHalfFloat native "OESTextureHalfFloat" {
- // To suppress missing implicit constructor warnings.
- factory OesTextureHalfFloat._() { throw new UnsupportedError("Not supported"); }
@DomName('OESTextureHalfFloat.HALF_FLOAT_OES')
@DocsEditable
@@ -842,8 +802,6 @@ class OesTextureHalfFloat native "OESTextureHalfFloat" {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float_linear/
@Experimental
class OesTextureHalfFloatLinear native "OESTextureHalfFloatLinear" {
- // To suppress missing implicit constructor warnings.
- factory OesTextureHalfFloatLinear._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -855,8 +813,6 @@ class OesTextureHalfFloatLinear native "OESTextureHalfFloatLinear" {
// http://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/
@Experimental // experimental
class OesVertexArrayObject native "OESVertexArrayObject" {
- // To suppress missing implicit constructor warnings.
- factory OesVertexArrayObject._() { throw new UnsupportedError("Not supported"); }
@DomName('OESVertexArrayObject.VERTEX_ARRAY_BINDING_OES')
@DocsEditable
@@ -891,8 +847,6 @@ class OesVertexArrayObject native "OESVertexArrayObject" {
@DomName('WebGLProgram')
@Unstable
class Program native "WebGLProgram" {
- // To suppress missing implicit constructor warnings.
- factory Program._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -903,8 +857,6 @@ class Program native "WebGLProgram" {
@DomName('WebGLRenderbuffer')
@Unstable
class Renderbuffer native "WebGLRenderbuffer" {
- // To suppress missing implicit constructor warnings.
- factory Renderbuffer._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -918,8 +870,6 @@ class Renderbuffer native "WebGLRenderbuffer" {
@Experimental
@Unstable
class RenderingContext extends CanvasRenderingContext native "WebGLRenderingContext" {
- // To suppress missing implicit constructor warnings.
- factory RenderingContext._() { throw new UnsupportedError("Not supported"); }
/// Checks if this type is supported on the current platform.
static bool get supported => JS('bool', '!!(window.WebGLRenderingContext)');
@@ -2768,8 +2718,6 @@ class RenderingContext extends CanvasRenderingContext native "WebGLRenderingCont
@DocsEditable
@DomName('WebGLShader')
class Shader native "WebGLShader" {
- // To suppress missing implicit constructor warnings.
- factory Shader._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -2779,8 +2727,6 @@ class Shader native "WebGLShader" {
@DocsEditable
@DomName('WebGLShaderPrecisionFormat')
class ShaderPrecisionFormat native "WebGLShaderPrecisionFormat" {
- // To suppress missing implicit constructor warnings.
- factory ShaderPrecisionFormat._() { throw new UnsupportedError("Not supported"); }
@DomName('WebGLShaderPrecisionFormat.precision')
@DocsEditable
@@ -2802,8 +2748,6 @@ class ShaderPrecisionFormat native "WebGLShaderPrecisionFormat" {
@DocsEditable
@DomName('WebGLTexture')
class Texture native "WebGLTexture" {
- // To suppress missing implicit constructor warnings.
- factory Texture._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -2813,8 +2757,6 @@ class Texture native "WebGLTexture" {
@DocsEditable
@DomName('WebGLUniformLocation')
class UniformLocation native "WebGLUniformLocation" {
- // To suppress missing implicit constructor warnings.
- factory UniformLocation._() { throw new UnsupportedError("Not supported"); }
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
// for details. All rights reserved. Use of this source code is governed by a
@@ -2826,6 +2768,4 @@ class UniformLocation native "WebGLUniformLocation" {
// http://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/
@Experimental // experimental
class VertexArrayObject native "WebGLVertexArrayObjectOES" {
- // To suppress missing implicit constructor warnings.
- factory VertexArrayObject._() { throw new UnsupportedError("Not supported"); }
}
« no previous file with comments | « sdk/lib/web_audio/dartium/web_audio_dartium.dart ('k') | sdk/lib/web_gl/dartium/web_gl_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698