Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: sdk/lib/web_gl/dartium/web_gl_dartium.dart

Issue 17508002: Revert "Making all DOM types abstract and removing superfluous Dartium constructors." (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « sdk/lib/web_gl/dart2js/web_gl_dart2js.dart ('k') | sdk/lib/web_sql/dart2js/web_sql_dart2js.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: sdk/lib/web_gl/dartium/web_gl_dartium.dart
diff --git a/sdk/lib/web_gl/dartium/web_gl_dartium.dart b/sdk/lib/web_gl/dartium/web_gl_dartium.dart
index 076acddb6523ea0550ba845360fb1c37c5fd7dd1..a1e5550c3a107f65173b888806f0484bb9550239 100644
--- a/sdk/lib/web_gl/dartium/web_gl_dartium.dart
+++ b/sdk/lib/web_gl/dartium/web_gl_dartium.dart
@@ -326,8 +326,7 @@ const int ZERO = RenderingContext.ZERO;
@DomName('WebGLActiveInfo')
@Unstable
class ActiveInfo extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory ActiveInfo._() { throw new UnsupportedError("Not supported"); }
+ ActiveInfo.internal();
@DomName('WebGLActiveInfo.name')
@DocsEditable
@@ -353,8 +352,7 @@ class ActiveInfo extends NativeFieldWrapperClass1 {
@DomName('WebGLBuffer')
@Unstable
class Buffer extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory Buffer._() { throw new UnsupportedError("Not supported"); }
+ Buffer.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -369,8 +367,7 @@ class Buffer extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_atc/
@Experimental
class CompressedTextureAtc extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory CompressedTextureAtc._() { throw new UnsupportedError("Not supported"); }
+ CompressedTextureAtc.internal();
@DomName('WebGLCompressedTextureATC.COMPRESSED_RGBA_ATC_EXPLICIT_ALPHA_WEBGL')
@DocsEditable
@@ -397,8 +394,7 @@ class CompressedTextureAtc extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_pvrtc/
@Experimental // experimental
class CompressedTexturePvrtc extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory CompressedTexturePvrtc._() { throw new UnsupportedError("Not supported"); }
+ CompressedTexturePvrtc.internal();
@DomName('WebGLCompressedTexturePVRTC.COMPRESSED_RGBA_PVRTC_2BPPV1_IMG')
@DocsEditable
@@ -429,8 +425,7 @@ class CompressedTexturePvrtc extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_compressed_texture_s3tc/
@Experimental // experimental
class CompressedTextureS3TC extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory CompressedTextureS3TC._() { throw new UnsupportedError("Not supported"); }
+ CompressedTextureS3TC.internal();
@DomName('WebGLCompressedTextureS3TC.COMPRESSED_RGBA_S3TC_DXT1_EXT')
@DocsEditable
@@ -460,8 +455,7 @@ class CompressedTextureS3TC extends NativeFieldWrapperClass1 {
@DomName('WebGLContextAttributes')
@Unstable
class ContextAttributes extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory ContextAttributes._() { throw new UnsupportedError("Not supported"); }
+ ContextAttributes.internal();
@DomName('WebGLContextAttributes.alpha')
@DocsEditable
@@ -523,8 +517,7 @@ class ContextAttributes extends NativeFieldWrapperClass1 {
@DomName('WebGLContextEvent')
@Unstable
class ContextEvent extends Event {
- // To suppress missing implicit constructor warnings.
- factory ContextEvent._() { throw new UnsupportedError("Not supported"); }
+ ContextEvent.internal() : super.internal();
@DomName('WebGLContextEvent.statusMessage')
@DocsEditable
@@ -543,8 +536,7 @@ class ContextEvent extends Event {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_debug_renderer_info/
@Experimental // experimental
class DebugRendererInfo extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory DebugRendererInfo._() { throw new UnsupportedError("Not supported"); }
+ DebugRendererInfo.internal();
@DomName('WebGLDebugRendererInfo.UNMASKED_RENDERER_WEBGL')
@DocsEditable
@@ -567,8 +559,7 @@ class DebugRendererInfo extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_debug_shaders/
@Experimental // experimental
class DebugShaders extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory DebugShaders._() { throw new UnsupportedError("Not supported"); }
+ DebugShaders.internal();
@DomName('WebGLDebugShaders.getTranslatedShaderSource')
@DocsEditable
@@ -587,8 +578,7 @@ class DebugShaders extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_depth_texture/
@Experimental // experimental
class DepthTexture extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory DepthTexture._() { throw new UnsupportedError("Not supported"); }
+ DepthTexture.internal();
@DomName('WebGLDepthTexture.UNSIGNED_INT_24_8_WEBGL')
@DocsEditable
@@ -607,8 +597,7 @@ class DepthTexture extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/specs/latest/
@Experimental // stable
class ExtDrawBuffers extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory ExtDrawBuffers._() { throw new UnsupportedError("Not supported"); }
+ ExtDrawBuffers.internal();
@DomName('EXTDrawBuffers.COLOR_ATTACHMENT0_EXT')
@DocsEditable
@@ -759,8 +748,7 @@ class ExtDrawBuffers extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/EXT_frag_depth/
@Experimental
class ExtFragDepth extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory ExtFragDepth._() { throw new UnsupportedError("Not supported"); }
+ ExtFragDepth.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -775,8 +763,7 @@ class ExtFragDepth extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/EXT_texture_filter_anisotropic/
@Experimental
class ExtTextureFilterAnisotropic extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory ExtTextureFilterAnisotropic._() { throw new UnsupportedError("Not supported"); }
+ ExtTextureFilterAnisotropic.internal();
@DomName('EXTTextureFilterAnisotropic.MAX_TEXTURE_MAX_ANISOTROPY_EXT')
@DocsEditable
@@ -798,8 +785,7 @@ class ExtTextureFilterAnisotropic extends NativeFieldWrapperClass1 {
@DomName('WebGLFramebuffer')
@Unstable
class Framebuffer extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory Framebuffer._() { throw new UnsupportedError("Not supported"); }
+ Framebuffer.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -814,8 +800,7 @@ class Framebuffer extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/WEBGL_lose_context/
@Experimental
class LoseContext extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory LoseContext._() { throw new UnsupportedError("Not supported"); }
+ LoseContext.internal();
@DomName('WebGLLoseContext.loseContext')
@DocsEditable
@@ -838,8 +823,7 @@ class LoseContext extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_element_index_uint/
@Experimental // experimental
class OesElementIndexUint extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory OesElementIndexUint._() { throw new UnsupportedError("Not supported"); }
+ OesElementIndexUint.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -854,8 +838,7 @@ class OesElementIndexUint extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_standard_derivatives/
@Experimental // experimental
class OesStandardDerivatives extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory OesStandardDerivatives._() { throw new UnsupportedError("Not supported"); }
+ OesStandardDerivatives.internal();
@DomName('OESStandardDerivatives.FRAGMENT_SHADER_DERIVATIVE_HINT_OES')
@DocsEditable
@@ -874,8 +857,7 @@ class OesStandardDerivatives extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_float/
@Experimental // experimental
class OesTextureFloat extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory OesTextureFloat._() { throw new UnsupportedError("Not supported"); }
+ OesTextureFloat.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -890,8 +872,7 @@ class OesTextureFloat extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_float_linear/
@Experimental
class OesTextureFloatLinear extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory OesTextureFloatLinear._() { throw new UnsupportedError("Not supported"); }
+ OesTextureFloatLinear.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -906,8 +887,7 @@ class OesTextureFloatLinear extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float/
@Experimental // experimental
class OesTextureHalfFloat extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory OesTextureHalfFloat._() { throw new UnsupportedError("Not supported"); }
+ OesTextureHalfFloat.internal();
@DomName('OESTextureHalfFloat.HALF_FLOAT_OES')
@DocsEditable
@@ -926,8 +906,7 @@ class OesTextureHalfFloat extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_texture_half_float_linear/
@Experimental
class OesTextureHalfFloatLinear extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory OesTextureHalfFloatLinear._() { throw new UnsupportedError("Not supported"); }
+ OesTextureHalfFloatLinear.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -942,8 +921,7 @@ class OesTextureHalfFloatLinear extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/
@Experimental // experimental
class OesVertexArrayObject extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory OesVertexArrayObject._() { throw new UnsupportedError("Not supported"); }
+ OesVertexArrayObject.internal();
@DomName('OESVertexArrayObject.VERTEX_ARRAY_BINDING_OES')
@DocsEditable
@@ -977,8 +955,7 @@ class OesVertexArrayObject extends NativeFieldWrapperClass1 {
@DomName('WebGLProgram')
@Unstable
class Program extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory Program._() { throw new UnsupportedError("Not supported"); }
+ Program.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -992,8 +969,7 @@ class Program extends NativeFieldWrapperClass1 {
@DomName('WebGLRenderbuffer')
@Unstable
class Renderbuffer extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory Renderbuffer._() { throw new UnsupportedError("Not supported"); }
+ Renderbuffer.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -1010,8 +986,7 @@ class Renderbuffer extends NativeFieldWrapperClass1 {
@Experimental
@Unstable
class RenderingContext extends CanvasRenderingContext {
- // To suppress missing implicit constructor warnings.
- factory RenderingContext._() { throw new UnsupportedError("Not supported"); }
+ RenderingContext.internal() : super.internal();
/// Checks if this type is supported on the current platform.
static bool get supported => true;
@@ -2849,8 +2824,7 @@ class RenderingContext extends CanvasRenderingContext {
@DocsEditable
@DomName('WebGLShader')
class Shader extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory Shader._() { throw new UnsupportedError("Not supported"); }
+ Shader.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -2863,8 +2837,7 @@ class Shader extends NativeFieldWrapperClass1 {
@DocsEditable
@DomName('WebGLShaderPrecisionFormat')
class ShaderPrecisionFormat extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory ShaderPrecisionFormat._() { throw new UnsupportedError("Not supported"); }
+ ShaderPrecisionFormat.internal();
@DomName('WebGLShaderPrecisionFormat.precision')
@DocsEditable
@@ -2889,8 +2862,7 @@ class ShaderPrecisionFormat extends NativeFieldWrapperClass1 {
@DocsEditable
@DomName('WebGLTexture')
class Texture extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory Texture._() { throw new UnsupportedError("Not supported"); }
+ Texture.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -2903,8 +2875,7 @@ class Texture extends NativeFieldWrapperClass1 {
@DocsEditable
@DomName('WebGLUniformLocation')
class UniformLocation extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory UniformLocation._() { throw new UnsupportedError("Not supported"); }
+ UniformLocation.internal();
}
// Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
@@ -2919,7 +2890,6 @@ class UniformLocation extends NativeFieldWrapperClass1 {
// http://www.khronos.org/registry/webgl/extensions/OES_vertex_array_object/
@Experimental // experimental
class VertexArrayObject extends NativeFieldWrapperClass1 {
- // To suppress missing implicit constructor warnings.
- factory VertexArrayObject._() { throw new UnsupportedError("Not supported"); }
+ VertexArrayObject.internal();
}
« no previous file with comments | « sdk/lib/web_gl/dart2js/web_gl_dart2js.dart ('k') | sdk/lib/web_sql/dart2js/web_sql_dart2js.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698