Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

Issue 1750583002: Revert "dart2js cps: Refactor tracking of side effects." (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
index 04630e969742e86a6d2e4cfbaf8304947c6d7ad7..dd69e3e497edfb8d239b08177ce8ef35d7b1af9d 100644
--- a/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart
@@ -269,14 +269,12 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitGetField(cps_ir.GetField node) {
String object = formatReference(node.object);
String field = node.field.name;
- String finalFlag = node.isFinal ? 'final' : 'non-final';
- return 'GetField $object.$field $finalFlag';
+ return 'GetField($object.$field)';
}
visitGetStatic(cps_ir.GetStatic node) {
String element = node.element.name;
- String finalFlag = node.isFinal ? 'final' : 'non-final';
- return 'GetStatic $element $finalFlag';
+ return 'GetStatic($element)';
}
visitSetStatic(cps_ir.SetStatic node) {
@@ -287,8 +285,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitGetLazyStatic(cps_ir.GetLazyStatic node) {
String element = node.element.name;
- String finalFlag = node.isFinal ? 'final' : 'non-final';
- return "GetLazyStatic $element $finalFlag";
+ return "GetLazyStatic $element";
}
visitCreateBox(cps_ir.CreateBox node) {
@@ -364,8 +361,7 @@ class IRTracer extends TracerUtil implements cps_ir.Visitor {
visitGetLength(cps_ir.GetLength node) {
String object = formatReference(node.object);
- String finalFlag = node.isFinal ? 'final' : 'non-final';
- return 'GetLength $object $finalFlag';
+ return 'GetLength $object';
}
visitGetIndex(cps_ir.GetIndex node) {
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698