Revert "dart2js cps: Refactor tracking of side effects."

pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.ir_tracer;
 
 import 'dart:async' show EventSink;
 import 'cps_ir_nodes.dart' as cps_ir;
 import '../tracer.dart';
 
@@ skipping 251 matching lines @@
   visitSetField(cps_ir.SetField node) {
     String object = formatReference(node.object);
     String field = node.field.name;
     String value = formatReference(node.value);
     return 'SetField $object.$field = $value';
   }
 
   visitGetField(cps_ir.GetField node) {
     String object = formatReference(node.object);
     String field = node.field.name;
-    String finalFlag = node.isFinal ? 'final' : 'non-final';
-    return 'GetField $object.$field $finalFlag';
+    return 'GetField($object.$field)';
   }
 
   visitGetStatic(cps_ir.GetStatic node) {
     String element = node.element.name;
-    String finalFlag = node.isFinal ? 'final' : 'non-final';
-    return 'GetStatic $element $finalFlag';
+    return 'GetStatic($element)';
   }
 
   visitSetStatic(cps_ir.SetStatic node) {
     String element = node.element.name;
     String value = formatReference(node.value);
     return 'SetStatic $element = $value';
   }
 
   visitGetLazyStatic(cps_ir.GetLazyStatic node) {
     String element = node.element.name;
-    String finalFlag = node.isFinal ? 'final' : 'non-final';
-    return "GetLazyStatic $element $finalFlag";
+    return "GetLazyStatic $element";
   }
 
   visitCreateBox(cps_ir.CreateBox node) {
     return 'CreateBox';
   }
 
   visitCreateInstance(cps_ir.CreateInstance node) {
     String className = node.classElement.name;
     String arguments = node.arguments.map(formatReference).join(', ');
     String typeInformation = formatReference(node.typeInformation);
@@ skipping 55 matching lines @@
 
   visitForeignCode(cps_ir.ForeignCode node) {
     String id = names.name(node);
     String arguments = node.arguments.map(formatReference).join(', ');
     printStmt(id,
         "ForeignCode ${node.type} ${node.codeTemplate.source} $arguments");
   }
 
   visitGetLength(cps_ir.GetLength node) {
     String object = formatReference(node.object);
-    String finalFlag = node.isFinal ? 'final' : 'non-final';
-    return 'GetLength $object $finalFlag';
+    return 'GetLength $object';
   }
 
   visitGetIndex(cps_ir.GetIndex node) {
     String object = formatReference(node.object);
     String index = formatReference(node.index);
     return 'GetIndex $object $index';
   }
 
   visitSetIndex(cps_ir.SetIndex node) {
     String object = formatReference(node.object);
@@ skipping 304 matching lines @@
   }
 
   visitBoundsCheck(cps_ir.BoundsCheck node) {
     unexpectedNode(node);
   }
 
   visitReceiverCheck(cps_ir.ReceiverCheck node) {
     unexpectedNode(node);
   }
 }