Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(478)

Issue 1750583002: Revert "dart2js cps: Refactor tracking of side effects." (Closed)

Created:
4 years, 9 months ago by asgerf
Modified:
4 years, 9 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "dart2js cps: Refactor tracking of side effects." This reverts commit 7f6c587de6654ea0b33d23d1c55a8f2a29316d1f. BUG= Committed: https://github.com/dart-lang/sdk/commit/a7fe3b140cf93f52cbed72d448c4229c4102ac6a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+372 lines, -408 lines) Patch
M pkg/compiler/lib/src/cps_ir/bounds_checker.dart View 4 chunks +60 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/builtin_operator.dart View 2 chunks +0 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 5 chunks +5 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 21 chunks +21 lines, -80 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 3 chunks +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart View 3 chunks +4 lines, -14 lines 0 comments Download
D pkg/compiler/lib/src/cps_ir/effects.dart View 1 chunk +0 lines, -197 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/gvn.dart View 17 chunks +173 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/loop_effects.dart View 4 chunks +104 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 5 chunks +0 lines, -23 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
asgerf
TBR Checked mode error after changes to isFinal
4 years, 9 months ago (2016-02-29 14:29:24 UTC) #2
asgerf
4 years, 9 months ago (2016-02-29 14:29:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
a7fe3b140cf93f52cbed72d448c4229c4102ac6a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698