Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 1750553002: Reduce weak callback stack reservation for non-main threads. (Closed)

Created:
4 years, 9 months ago by sof
Modified:
4 years, 9 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, oilpan-reviews, Mads Ager (chromium), blink-reviews, kinuko+watch, kouhei+heap_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reduce weak callback stack reservation for non-main threads. Tune the initial reservation for Oilpan threads other than the main thread; very few uses of weak references and collections happen off the main thread. Adjust the initial allocation accordingly. R= BUG= Committed: https://crrev.com/6461c7d047bc1f74f8500e293eb95282090fff3c Cr-Commit-Position: refs/heads/master@{#378318}

Patch Set 1 #

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/heap/CallbackStack.h View 1 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/heap/ThreadState.cpp View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
sof
please take a look.
4 years, 9 months ago (2016-02-29 18:31:00 UTC) #2
haraken
LGTM
4 years, 9 months ago (2016-02-29 23:26:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1750553002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1750553002/20001
4 years, 9 months ago (2016-02-29 23:27:23 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-02-29 23:55:03 UTC) #6
commit-bot: I haz the power
4 years, 9 months ago (2016-02-29 23:56:02 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/6461c7d047bc1f74f8500e293eb95282090fff3c
Cr-Commit-Position: refs/heads/master@{#378318}

Powered by Google App Engine
This is Rietveld 408576698