third_party/WebKit/Source/platform/heap/ThreadState.cpp - Issue 1750553002: Reduce weak callback stack reservation for non-main threads.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/heap/ThreadState.cpp

Issue 1750553002: Reduce weak callback stack reservation for non-main threads. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: whitespace Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: third_party/WebKit/Source/platform/heap/ThreadState.cpp

diff --git a/third_party/WebKit/Source/platform/heap/ThreadState.cpp b/third_party/WebKit/Source/platform/heap/ThreadState.cpp

index ce9f9f8ba011a45581217a76cb6c1985175b0d9f..664912e0808a04039fe4dfcf05f5456d0f8f4160 100644

--- a/third_party/WebKit/Source/platform/heap/ThreadState.cpp

+++ b/third_party/WebKit/Source/platform/heap/ThreadState.cpp

@@ -131,7 +131,10 @@ ThreadState::ThreadState()

m_likelyToBePromptlyFreed = adoptArrayPtr(new int[likelyToBePromptlyFreedArraySize]);

clearHeapAges();

- m_threadLocalWeakCallbackStack = new CallbackStack();

+ // There is little use of weak references and collections off the main thread;

+ // use a much lower initial block reservation.

+ size_t initialBlockSize = isMainThread() ? CallbackStack::kDefaultBlockSize : CallbackStack::kMinimalBlockSize;

+ m_threadLocalWeakCallbackStack = new CallbackStack(initialBlockSize);

}

ThreadState::~ThreadState()

« no previous file with comments | « third_party/WebKit/Source/platform/heap/CallbackStack.h ('k') | no next file » | no next file with comments »