Issue 175053004: <webview>: Report a better message if plugin not loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 175053004: <webview>: Report a better message if plugin not loaded. (Closed)

Created:
6 years, 10 months ago by Fady Samuel

Modified:
6 years, 10 months ago

Reviewers:
sadrul

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Visibility:
Public.

More Reviews

Description

<webview>: Report a better message if plugin not loaded. Currently, if <webview> is navigated to a page with an unsupported plugin, it'll show a "Looking for plugin..." placeholder indefinitely. With this CL, if there is an unsupport plugin then the message: "No plugin available to display this content." will be shown instead. BUG=345348 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252828

Patch Set 1 #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/guestview/webview/plugin_permission_helper.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fsamuel@chromium.org/175053004/1

6 years, 10 months ago (2014-02-22 21:23:50 UTC) #4

Message was sent while issue was closed.

Change committed as 252828

Expand Messages | Collapse Messages