chrome/browser/guestview/webview/plugin_permission_helper.cc - Issue 175053004: <webview>: Report a better message if plugin not loaded.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/guestview/webview/plugin_permission_helper.cc

Issue 175053004: <webview>: Report a better message if plugin not loaded. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/guestview/webview/plugin_permission_helper.cc

diff --git a/chrome/browser/guestview/webview/plugin_permission_helper.cc b/chrome/browser/guestview/webview/plugin_permission_helper.cc

index e5c348236db91dd4a19c0dc6b0e0158bae56a942..a4fd5d48adecba93641ee3597e1d93200b87ff36 100644

--- a/chrome/browser/guestview/webview/plugin_permission_helper.cc

+++ b/chrome/browser/guestview/webview/plugin_permission_helper.cc

@@ -92,6 +92,7 @@ void PluginPermissionHelper::OnOpenAboutPlugins() {

#if defined(ENABLE_PLUGIN_INSTALLATION)

void PluginPermissionHelper::OnFindMissingPlugin(int placeholder_id,

const std::string& mime_type) {

+ Send(new ChromeViewMsg_DidNotFindMissingPlugin(placeholder_id));

}

void PluginPermissionHelper::OnRemovePluginPlaceholderHost(int placeholder_id) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »