Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3226)

Unified Diff: chrome/browser/ui/views/toolbar/app_menu_button.cc

Issue 1750403005: [MD] some tweaks to download shelf (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/download/download_item_view_md.cc ('k') | ui/gfx/geometry/insets.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/toolbar/app_menu_button.cc
diff --git a/chrome/browser/ui/views/toolbar/app_menu_button.cc b/chrome/browser/ui/views/toolbar/app_menu_button.cc
index 12c0e38dfdc7ac277baa9d7eda618c0c97d26bf7..a9aa56e3f9f5f596dee7e734da0744602257406f 100644
--- a/chrome/browser/ui/views/toolbar/app_menu_button.cc
+++ b/chrome/browser/ui/views/toolbar/app_menu_button.cc
@@ -190,13 +190,8 @@ void AppMenuButton::SetTrailingMargin(int margin) {
gfx::Point AppMenuButton::GetInkDropCenter() const {
// ToolbarView extends the bounds of the app button to the right in maximized
- // mode. So instead of using the center point of local bounds, we use the
- // center point (adjusted for RTL layouts) of the preferred size, which
- // doesn't change in maximized mode.
- const int visible_width = GetPreferredSize().width();
- return gfx::Point(
- (GetMirroredXWithWidthInView(0, visible_width) + visible_width) / 2,
- height() / 2);
+ // mode.
+ return image()->bounds().CenterPoint();
varkha 2016/03/03 04:39:10 This seems wrong. I am running with --lang=he in c
}
const char* AppMenuButton::GetClassName() const {
« no previous file with comments | « chrome/browser/ui/views/download/download_item_view_md.cc ('k') | ui/gfx/geometry/insets.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698